All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Hellstrom <thellstrom@vmware.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Thomas Hellstrom <thellstrom@vmware.com>,
	dri-devel@lists.freedesktop.org, Takashi Iwai <tiwai@suse.de>,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 2/2] drm: Serialise multiple event readers
Date: Thu, 26 Nov 2015 12:19:43 +0100	[thread overview]
Message-ID: <5656EACF.5060409@vmware.com> (raw)
In-Reply-To: <20151125145605.GA22980@nuc-i3427.alporthouse.com>

On 11/25/2015 03:56 PM, Chris Wilson wrote:
> On Wed, Nov 25, 2015 at 03:44:04PM +0100, Thomas Hellstrom wrote:
>> Do you need to take the mutex around other event pullers as well?
> We would. I checked in drm/*.c for other users, but not the drivers.
> A quick git grep doesn't show any likely candidates, they appear to be
> private event lists.
>
>

Indeed. I was confused by some exynos code I didn't look at too
carefully. Also vmwgfx has some code to pull events, but it is not
called until release time so it can't race.

So for the series:
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
 
Thanks for fixing this.

/Thomas

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-11-26 11:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5654CD76.8000107@vmware.com>
2015-11-24 22:14 ` drm_read() to paged-out memory area Chris Wilson
2015-11-25  6:46   ` Thomas Hellstrom
2015-11-25 11:24   ` Chris Wilson
2015-11-25 14:39 ` [PATCH 1/2] drm: Drop dev->event_lock spinlock around faulting copy_to_user() Chris Wilson
2015-11-25 14:39   ` [PATCH 2/2] drm: Serialise multiple event readers Chris Wilson
2015-11-25 14:44     ` Thomas Hellstrom
2015-11-25 14:56       ` Chris Wilson
2015-11-26 11:19         ` Thomas Hellstrom [this message]
2015-11-26 14:21           ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5656EACF.5060409@vmware.com \
    --to=thellstrom@vmware.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.