From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manfred Schlaegl Subject: Re: [RFC PATCH 1/2] drm: add support for for clk and de polarity Date: Thu, 26 Nov 2015 15:20:51 +0100 Message-ID: <56571543.20701@gmx.at> References: <55A67FDB.8010602@gmx.at> <55A6813A.8090706@gmx.at> <1448472141.3390.17.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1448472141.3390.17.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philipp Zabel Cc: linux-fbdev@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Manfred Schlaegl , Tomi Valkeinen , Steve Longerbeam , Deepak Das , Jean-Christophe Plagniol-Villard List-Id: linux-api@vger.kernel.org T24gMjAxNS0xMS0yNSAxODoyMiwgUGhpbGlwcCBaYWJlbCB3cm90ZToKPiBBbSBNaXR0d29jaCwg ZGVuIDE1LjA3LjIwMTUsIDE3OjUwICswMjAwIHNjaHJpZWIgTWFuZnJlZCBTY2hsYWVnbDoKPj4g VG8gZ2V0IGZ1bGwgc3VwcG9ydCBmb3IgcGFyYWxsZWwgYW5kIExWRFMgZGlzcGxheXMgd2l0aCBk cm06Cj4+IEFkZCByZXByZXNlbnRhdGlvbiBmb3IgY2xvY2sgYW5kIGRhdGEgZW5hYmxlIHBvbGFy aXR5IGluIGRybV9kaXNwbGF5X21vZGUKPj4gZmxhZ3MgKHNpbWlsYXIgdG8gSFNZTkMvVlNZTkMg cG9sYXJpdHkpIGFuZCB1cGRhdGUgY29udmVyc2lvbiBmdW5jdGlvbnMKPj4gZnJvbS90byB2aWRl b21vZGUgYWNjb3JkaW5nbHkuCj4+Cj4+IFRoaXMgaXMgZXNwZWNpYWxseSBpbXBvcnRhbnQgZm9y IGVtYmVkZGVkIGRldmljZXMgd2hlcmUgcGFyYWxsZWwoUkdCKSBhbmQKPj4gTFZEUyBkaXNwbGF5 cyBhcmUgc3RpbGwgd2lkZWx5IHVzZWQgYW5kIGRybSBhbHJlYWR5IHBsYXlzIGFuIGltcG9ydGFu dAo+PiByb2xlLgo+Pgo+PiBUZXN0ZWQgb24gRnJlZXNjYWxlIGkuTVg1MyhwYXJhbGxlbCkgYW5k IGkuTVg2KExWRFMpLgo+Pgo+PiBCYWNrZ3JvdW5kOgo+PiBUaGVyZSB3YXMgdGhlIGFiaWxpdHkg dG8gc2V0IHBvbGFyaXR5IG9mIGNsb2NrIGFuZCBkYXRhIGVuYWJsZSBzaWduYWxzCj4+IGluIGRl dmljZXRyZWUoZGlzcGxheS10aW1pbmcpLCBzdHJ1Y3QgZGlzcGxheV90aW1pbmcgYW5kIHN0cnVj dCB2aWRlb21vZGUsCj4+IGJ1dCB0aGVyZSB3YXMgbm8gcmVwcmVzZW50YXRpb24gZm9yIHRoaXMg aW4gc3RydWN0IGRybV9kaXNwbGF5X21vZGUuCj4+IEV4YW1wbGUgb24gRnJlZXNjYWxlIGkuTVg1 My9pLk1YNiBTb0MnczoKPj4gICogQSBwYXJhbGxlbCBkaXNwbGF5IHVzaW5nIGRpZmZlcmVudCBj bG9jayBwb2xhcml0eSBpcyBzZXQgdXAgdXNpbmcKPj4gICAgZGlzcGxheS10aW1pbmcgaW4gZGV2 aWNldHJlZQo+PiAgKiBpcHV2MyBwYXJhbGxlbCBvdXRwdXRzIGNsb2NrIHdpdGggd3JvbmcgcG9s YXJpdHkKPj4KPj4gU2lnbmVkLW9mZi1ieTogTWFuZnJlZCBTY2hsYWVnbCA8bWFuZnJlZC5zY2hs YWVnbEBnbXguYXQ+Cj4gCj4gQW55IGNvbW1lbnRzIG9uIHdoZXRoZXIgZGF0YSBlbmFibGUgYW5k IHBpeGVsIGNsb2NrIHBvbGFyaXR5IGZsYWdzIGNhbgo+IGJlIGFkZGVkIHRvIHRoZSB2aXNpYmxl IERSTV9NT0RFX0ZMQUdzLCBhbmQgaWYgbm90LCB3aGVyZSBlbHNlIHRoaXMKPiBpbmZvcm1hdGlv biBzaG91bGQgYmUga2VwdD8gc3RydWN0IGRybV9kaXNwbGF5X2luZm8/Cj4gCj4gVGhpcyBwYXRj aCBhbmQgdGhlIGZvbGxvd2luZyBJUFV2MyBwYXRjaCBhcmUgdXNlZnVsIGFuZCBuZWNlc3Nhcnkg Zm9yCj4gcXVpdGUgc29tZSBwYW5lbHMgY29ubmVjdGVkIHRvIGkuTVggU29DcywgYnV0IGFkZGlu ZyBEUk1fTU9ERV9GTEFHcyBpcwo+IHNvbWV3aGF0IG91dCBvZiBteSBqdXJpc2RpY3Rpb24uCj4g Cj4gYmVzdCByZWdhcmRzCj4gUGhpbGlwcAo+IAoKR29vZCB0byBzZWUgdGhhdCB0aGlzIGRpc2N1 c3Npb24gaXMgdHJpZ2dlcmVkLgoKU3RhdGUgb2YgdGhlIHNlbnQgcGF0Y2hlcyByZXNwZWN0aXZl IHRvIGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC90b3J2YWxk cy9saW51eC5naXQgKDc4YzRhNDkpCiAqIFtSRkMgUEFUQ0ggMS8yXSBkcm06IGFkZCBzdXBwb3J0 IGZvciBmb3IgY2xrIGFuZCBkZSBwb2xhcml0eQogICAqIGFwcGxpZXMgdW5tb2RpZmllZAogKiBb UkZDIFBBVENIIDIvMl0gZ3B1OiBpcHUtdjM6IHVzZSBjbG9jayBhbmQgZGUgcG9sYXJpdHkgZnJv bSB2aWRlb21vZGUKICAgKiBkb2VzIG5vdCBhcHBseSAtPiBidXQgdGhpcyBjYW4gYmUgZml4ZWQg d2l0aCBjb3JyZWN0aW9ucyBvZiBsaW5lIG9mZnNldHMgKHVzaW5nIHBhdGNoKQpGcm9tIGEgY29k ZSByZXZpZXcgSSB0aGluayB0aGUgbW9kaWZpY2F0aW9ucyBtdXN0IHdvcmssIGJ1dCBJIGRpZCBu byB0ZXN0aW5nIG9uIGtlcm5lbCB2ZXJzaW9ucyBuZXdlciB0aGFuIDQuMS4xMy4KT24gZGVtYW5k LCBJIGNhbiByZWRvIHRlc3RzIG9uIHNvbWUgb2Ygb3VyIGkuTVg1MyAocGFyYWxsZWwpIGFuZCBp Lk1YNiAobHZkcykgYm9hcmRzIGFuZCBzZW5kIGFjdHVhbCBwYXRjaGVzLgoKYmVzdCByZWdhcmRz LApNYW5mcmVkCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manfred Schlaegl Date: Thu, 26 Nov 2015 14:20:51 +0000 Subject: Re: [RFC PATCH 1/2] drm: add support for for clk and de polarity Message-Id: <56571543.20701@gmx.at> List-Id: References: <55A67FDB.8010602@gmx.at> <55A6813A.8090706@gmx.at> <1448472141.3390.17.camel@pengutronix.de> In-Reply-To: <1448472141.3390.17.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Philipp Zabel Cc: linux-fbdev@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Manfred Schlaegl , Tomi Valkeinen , Steve Longerbeam , Deepak Das , Jean-Christophe Plagniol-Villard On 2015-11-25 18:22, Philipp Zabel wrote: > Am Mittwoch, den 15.07.2015, 17:50 +0200 schrieb Manfred Schlaegl: >> To get full support for parallel and LVDS displays with drm: >> Add representation for clock and data enable polarity in drm_display_mode >> flags (similar to HSYNC/VSYNC polarity) and update conversion functions >> from/to videomode accordingly. >> >> This is especially important for embedded devices where parallel(RGB) and >> LVDS displays are still widely used and drm already plays an important >> role. >> >> Tested on Freescale i.MX53(parallel) and i.MX6(LVDS). >> >> Background: >> There was the ability to set polarity of clock and data enable signals >> in devicetree(display-timing), struct display_timing and struct videomode, >> but there was no representation for this in struct drm_display_mode. >> Example on Freescale i.MX53/i.MX6 SoC's: >> * A parallel display using different clock polarity is set up using >> display-timing in devicetree >> * ipuv3 parallel outputs clock with wrong polarity >> >> Signed-off-by: Manfred Schlaegl > > Any comments on whether data enable and pixel clock polarity flags can > be added to the visible DRM_MODE_FLAGs, and if not, where else this > information should be kept? struct drm_display_info? > > This patch and the following IPUv3 patch are useful and necessary for > quite some panels connected to i.MX SoCs, but adding DRM_MODE_FLAGs is > somewhat out of my jurisdiction. > > best regards > Philipp > Good to see that this discussion is triggered. State of the sent patches respective to git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git (78c4a49) * [RFC PATCH 1/2] drm: add support for for clk and de polarity * applies unmodified * [RFC PATCH 2/2] gpu: ipu-v3: use clock and de polarity from videomode * does not apply -> but this can be fixed with corrections of line offsets (using patch) >From a code review I think the modifications must work, but I did no testing on kernel versions newer than 4.1.13. On demand, I can redo tests on some of our i.MX53 (parallel) and i.MX6 (lvds) boards and send actual patches. best regards, Manfred From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751930AbbKZOVP (ORCPT ); Thu, 26 Nov 2015 09:21:15 -0500 Received: from mout.gmx.net ([212.227.17.22]:63149 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbbKZOVN (ORCPT ); Thu, 26 Nov 2015 09:21:13 -0500 Message-ID: <56571543.20701@gmx.at> Date: Thu, 26 Nov 2015 15:20:51 +0100 From: Manfred Schlaegl User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Philipp Zabel CC: David Airlie , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Manfred Schlaegl , Steve Longerbeam , Deepak Das , Jiada Wang , linux-fbdev@vger.kernel.org Subject: Re: [RFC PATCH 1/2] drm: add support for for clk and de polarity References: <55A67FDB.8010602@gmx.at> <55A6813A.8090706@gmx.at> <1448472141.3390.17.camel@pengutronix.de> In-Reply-To: <1448472141.3390.17.camel@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:P/t0LqShxX76FSpxynYgPGtiWrmBbYJ1ZkLTL3ch6Hi6MYfxZaa nuNawOjJEGnUVjhu6L2XvQDsAKoCAe/rbND5vUVM4Xn6KqDm9omDiEdFHWydYqspYknldHw jJBThL/3RIorFg1iltRQpC6yv0lf7qa34sKXGI+vn4GOGr/cDb6jmdOZJ3Eu8cAXRNG1WXp Zp5TIUCbxWe039TinRhTQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:hu1mOjsA/ro=:ICbUAiwxU2CPKsBGEwEAXK On1lRkxWo+rFEmwVsWhxFdYfYw+i1e1Y3PZ1Bx6pmYHMt+9Wqxv5737grfhQHESAZjyymbTZt +ZPEnJB97beKtxpo9fHcY4mZiEvBD0wupylBX6wV6pXn32n7OiJM3KlgoZKdTobcldn/4oWYo QSRISThcT+56niTZqtTaTvxh4mO+bcd/bephseaPdC6yaWg6gMKve//32upGvLjud9gNK63Vr hGlSnGOTW1f+NBssrTyOlP1t0GC+32rM5no1a8nkfUukXx6epVmgOuoKtt57SWnNVyJL1Inz5 vaG1ef1XRwtaKHSK7+4tmE2eGoAcYN8uYnzPAfGOllgE804GEtaEqKwt0xjkaTaJ4c1zpkqbQ QkMixm9TqXJUp3GFssc2L3CLJnpmyXLpft6zG7qd5aijcad+dyQZmSKLjUJhtoN2BoVVQzR/V b8lSl12AwxPvvYIj2wc+hpHOT24NLBoPsVnbh4sobGRe23To5Tzt4vaqvG6WW2h8OW62ji+4c GqlkwEJtcaBUo9SLGn4SdnXc8LV8u0Tx78Z4oqWCUqnPh0D/cFoWjbNW/MDRG8fHsQbfsdh9X LPbGgmWQxr+EHYS3QSabO8bSutu87Yvw4gQqXiMFsn8C72MGufPVqWCMj4eWPV74S0ekfsBoT bplhxSnjjs6QT417eHKqvPrKuqAx5tpyC+VINCWPsrprSUlvtL+I9/HteZecefZb77svxgd/W z4Q0wdk9LY1jhcfOleJeuCwEUb7gwj1bBRTxyt/6lFhUGInTSYJBufU36cZaaUGh53pJ8CC2N +EnR75B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015-11-25 18:22, Philipp Zabel wrote: > Am Mittwoch, den 15.07.2015, 17:50 +0200 schrieb Manfred Schlaegl: >> To get full support for parallel and LVDS displays with drm: >> Add representation for clock and data enable polarity in drm_display_mode >> flags (similar to HSYNC/VSYNC polarity) and update conversion functions >> from/to videomode accordingly. >> >> This is especially important for embedded devices where parallel(RGB) and >> LVDS displays are still widely used and drm already plays an important >> role. >> >> Tested on Freescale i.MX53(parallel) and i.MX6(LVDS). >> >> Background: >> There was the ability to set polarity of clock and data enable signals >> in devicetree(display-timing), struct display_timing and struct videomode, >> but there was no representation for this in struct drm_display_mode. >> Example on Freescale i.MX53/i.MX6 SoC's: >> * A parallel display using different clock polarity is set up using >> display-timing in devicetree >> * ipuv3 parallel outputs clock with wrong polarity >> >> Signed-off-by: Manfred Schlaegl > > Any comments on whether data enable and pixel clock polarity flags can > be added to the visible DRM_MODE_FLAGs, and if not, where else this > information should be kept? struct drm_display_info? > > This patch and the following IPUv3 patch are useful and necessary for > quite some panels connected to i.MX SoCs, but adding DRM_MODE_FLAGs is > somewhat out of my jurisdiction. > > best regards > Philipp > Good to see that this discussion is triggered. State of the sent patches respective to git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git (78c4a49) * [RFC PATCH 1/2] drm: add support for for clk and de polarity * applies unmodified * [RFC PATCH 2/2] gpu: ipu-v3: use clock and de polarity from videomode * does not apply -> but this can be fixed with corrections of line offsets (using patch) >>From a code review I think the modifications must work, but I did no testing on kernel versions newer than 4.1.13. On demand, I can redo tests on some of our i.MX53 (parallel) and i.MX6 (lvds) boards and send actual patches. best regards, Manfred