All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
	Kan Liang <kan.liang@intel.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Andi Kleen <andi@firstfloor.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 2/3] perf callchain: Stop resolving callchains after invalid address
Date: Thu, 26 Nov 2015 08:48:17 -0700	[thread overview]
Message-ID: <565729C1.4030802@gmail.com> (raw)
In-Reply-To: <20151126150018.GA21474@danjae.kornet>

On 11/26/15 8:00 AM, Namhyung Kim wrote:
> Hi David,
>
> On Thu, Nov 26, 2015 at 06:14:57AM -0700, David Ahern wrote:
>> On 11/26/15 12:08 AM, Namhyung Kim wrote:
>>> @@ -528,11 +529,16 @@ int main(int argc, const char **argv)
>>>   {
>>>   	const char *cmd;
>>>   	char sbuf[STRERR_BUFSIZE];
>>> +	int min_addr;
>>>
>>>   	/* The page_size is placed in util object. */
>>>   	page_size = sysconf(_SC_PAGE_SIZE);
>>>   	cacheline_size = sysconf(_SC_LEVEL1_DCACHE_LINESIZE);
>>>
>>> +	if (sysctl__read_int("vm/mmap_min_addr", &min_addr) < 0)
>>
>> This assumes the record and analysis are done on the same system.
>
> Right.  Maybe we can just use minimal size (or page size?) or save and
> pass it through somewhere in the feature bit?

no preference, but it should work with cross arch analysis as well 
(e.g., record on arm/ppc and analysis on x86)


  reply	other threads:[~2015-11-26 15:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26  7:08 [PATCH 1/3] perf top: Fix freeze on --call-graph flat/folded Namhyung Kim
2015-11-26  7:08 ` [PATCH 2/3] perf callchain: Stop resolving callchains after invalid address Namhyung Kim
2015-11-26  7:43   ` Ingo Molnar
2015-11-26 14:12     ` Namhyung Kim
2015-11-27  7:48       ` Ingo Molnar
2015-11-26 13:14   ` David Ahern
2015-11-26 15:00     ` Namhyung Kim
2015-11-26 15:48       ` David Ahern [this message]
2015-11-26 15:58         ` Jiri Olsa
2015-11-26 16:19           ` Arnaldo Carvalho de Melo
2015-12-02  5:20             ` Namhyung Kim
2015-11-26  7:08 ` [PATCH 3/3] perf callchain: Honor hide_unresolved Namhyung Kim
2015-11-26  8:46   ` Jiri Olsa
2015-11-26 16:20     ` Arnaldo Carvalho de Melo
2015-11-27  7:43   ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-11-26  8:38 ` [PATCH 1/3] perf top: Fix freeze on --call-graph flat/folded Jiri Olsa
2015-11-26 13:52   ` Namhyung Kim
2015-11-26 14:00     ` Jiri Olsa
2015-11-26 15:10       ` Namhyung Kim
2015-11-26 15:22         ` Jiri Olsa
2015-11-26 16:32 ` Arnaldo Carvalho de Melo
2015-11-27  7:43 ` [tip:perf/core] " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565729C1.4030802@gmail.com \
    --to=dsahern@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.