All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Tyler Baker <tyler.baker@linaro.org>
Cc: frankja@linux.vnet.ibm.com, kvm@vger.kernel.org,
	pbonzini@redhat.com, pmorel@linux.vnet.ibm.com,
	dan.carpenter@oracle.com, "Kevin's boot bot" <khilman@kernel.org>
Subject: Re: [PATCH 2/2] KVM: Create debugfs dir and stat files for each VM
Date: Thu, 26 Nov 2015 21:47:18 +0100	[thread overview]
Message-ID: <56576FD6.40506@de.ibm.com> (raw)
In-Reply-To: <CANMBJr7phOF3ZWzccdQLLDSwutQHMVXvha5S_zViYd5CBk6a8w@mail.gmail.com>

On 11/26/2015 05:17 PM, Tyler Baker wrote:
> Hi Christian,
> 
> The kernelci.org bot recently has been reporting kvm guest boot
> failures[1] on various arm64 platforms in next-20151126. The bot
> bisected[2] the failures to the commit in -next titled "KVM: Create
> debugfs dir and stat files for each VM". I confirmed by reverting this
> commit on top of next-20151126 it resolves the boot issue.
> 
> In this test case the host and guest are booted with the same kernel.
> The host is booted over nfs, installs qemu (qemu-system arm64 2.4.0),
> and launches a guest. The host is booting fine, but when the guest is
> launched it errors with "Failed to retrieve host CPU features!". I
> checked the host logs, and found an "Unable to handle kernel paging
> request" splat[3] which occurs when the guest is attempting to start.
> 
> I scanned the patch in question but nothing obvious jumped out at me,
> any thoughts?

Not really.
Do you have processing running that do read the files in /sys/kernel/debug/kvm/* ?

If I read the arm oops message correctly it oopsed inside 
__srcu_read_lock. there is actually nothing in there that can oops, 
except the access to the preempt count. I am just guessing right now,
but maybe the preempt variable is no longer available (as the process
is gone). As long as a debugfs file is open, we hold a reference to 
the kvm, which holds a reference to the mm, so the mm might be killed
after the process. But this is supposed to work, so maybe its something
different. An objdump of __srcu_read_lock might help.

I will drop it from my tree until we understand the problem

Christian


  reply	other threads:[~2015-11-26 20:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26 16:17 [PATCH 2/2] KVM: Create debugfs dir and stat files for each VM Tyler Baker
2015-11-26 20:47 ` Christian Borntraeger [this message]
2015-11-27  8:54   ` Christian Borntraeger
2015-11-27 17:08     ` Tyler Baker
2015-11-27 18:53       ` Tyler Baker
2015-11-27 20:42         ` Tyler Baker
2015-11-30  8:37           ` Janosch Frank
2015-11-30 15:10             ` Alex Bennée
2015-11-30  8:38           ` Christian Borntraeger
2015-11-30 17:00             ` Tyler Baker
2016-02-02 17:15             ` Paolo Bonzini
2016-02-02 19:37               ` Christian Borntraeger
  -- strict thread matches above, loose matches on Subject: below --
2015-11-23 11:24 [PATCH v2 0/2] RFC: kvm stat enhancements Christian Borntraeger
2015-11-23 11:24 ` [PATCH 2/2] KVM: Create debugfs dir and stat files for each VM Christian Borntraeger
2015-11-18 13:11 [PATCH 0/2] kvm: provide kvm stat per process Christian Borntraeger
2015-11-18 13:11 ` [PATCH 2/2] KVM: Create debugfs dir and stat files for each VM Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56576FD6.40506@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=dan.carpenter@oracle.com \
    --cc=frankja@linux.vnet.ibm.com \
    --cc=khilman@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=pmorel@linux.vnet.ibm.com \
    --cc=tyler.baker@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.