Re: [PATCH] drm/amdgpu: fix userptr flags check

From: "Michel Dänzer" <michel@daenzer.net>
To: "Christian König" <deathsimple@vodafone.de>, alexdeucher@gmail.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: fix userptr flags check
Date: Fri, 27 Nov 2015 11:42:52 +0900	[thread overview]
Message-ID: <5657C32C.1090600@daenzer.net> (raw)
In-Reply-To: <1448532380-8289-1-git-send-email-deathsimple@vodafone.de>

On 26.11.2015 19:06, Christian König wrote:
> From: Christian König <christian.koenig@amd.com>
> 
> That got messed up while porting it from Radeon.
> 
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Cc: stable@vger.kernel.org
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> index 00c5b58..af53215 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> @@ -242,8 +242,9 @@ int amdgpu_gem_userptr_ioctl(struct drm_device *dev, void *data,
>  	    AMDGPU_GEM_USERPTR_REGISTER))
>  		return -EINVAL;
>  
> -	if (!(args->flags & AMDGPU_GEM_USERPTR_ANONONLY) ||
> -		   !(args->flags & AMDGPU_GEM_USERPTR_REGISTER)) {
> +	if (!(args->flags & AMDGPU_GEM_USERPTR_READONLY) && (
> +	     !(args->flags & AMDGPU_GEM_USERPTR_ANONONLY) ||
> +	     !(args->flags & AMDGPU_GEM_USERPTR_REGISTER))) {
>  
>  		/* if we want to write to it we must require anonymous
>  		   memory and install a MMU notifier */
> 

Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel