From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/2] x86/cpu: Introduce
	cpu_dev.c_early_init()
Date: Fri, 27 Nov 2015 09:59:11 +0000
Message-ID: <5658296F.3070505@citrix.com>
References: <1448557140-23040-1-git-send-email-andrew.cooper3@citrix.com>
	<5658214E02000078000B98CE@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5658214E02000078000B98CE@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 27/11/15 08:24, Jan Beulich wrote:
>>>> On 26.11.15 at 17:58, <andrew.cooper3@citrix.com> wrote:
>> The name is chosen to be consistent with Linux.  Doing this allows
>> early_intel_workaround() to be removed from common code.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> with one adjustment suggestion (which I'll do on commit unless you
> object):

Absolutely fine.

>
>> --- a/xen/arch/x86/cpu/intel.c
>> +++ b/xen/arch/x86/cpu/intel.c
>> @@ -156,10 +156,8 @@ static void __devinit set_cpuidmask(const struct cpuinfo_x86 *c)
>>  	}
>>  }
>>  
>> -void __devinit early_intel_workaround(struct cpuinfo_x86 *c)
>> +static void __devinit early_init_intel(struct cpuinfo_x86 *c)
> The __devinit should be dropped here considering that we mean
> to drop them gradually anyway.

I shall dust off my series which drops them all.

~Andrew