From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Hellstrom Subject: Re: [PATCH 1/2] drm: Avoid calling the cursor_set2 callback from the drm_mode_cursor ioctl Date: Fri, 27 Nov 2015 12:42:15 +0100 Message-ID: <56584197.3020707@vmware.com> References: <1448563935-3157-1-git-send-email-thellstrom@vmware.com> <20151127101133.GW17050@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp-outbound-1.vmware.com (smtp-outbound-1.vmware.com [208.91.2.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 059606E275 for ; Fri, 27 Nov 2015 03:42:20 -0800 (PST) In-Reply-To: <20151127101133.GW17050@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: airlied@redhat.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gMTEvMjcvMjAxNSAxMToxMSBBTSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBPbiBUaHUsIE5v diAyNiwgMjAxNSBhdCAxMDo1MjoxNEFNIC0wODAwLCBUaG9tYXMgSGVsbHN0cm9tIHdyb3RlOgo+ PiBJZiB0aGUgZHJtX21vZGVfY3Vyc29yX2lvY3RsIGlzIGNhbGxlZCBhbmQgdGhlIGN1cnNvcl9z ZXQyIGNhbGxiYWNrIGlzCj4+IGltcGxlbWVudGVkLCB0aGUgY3Vyc29yIGhvdHNwb3QgaXMgc2V0 IHRvICgwLDApIHdoaWNoIGlzIGluY29tcGF0aWJsZQo+PiB3aXRoIHZtd2dmeCB3aGVyZSB0aGUg aG90c3BvdCBzaG91bGQgaW5zdGVhZCByZW1haW4gdW5jaGFuZ2VkLgo+Pgo+PiBTbyBpZiB0aGUg ZHJpdmVyIGltcGxlbWVudHMgYm90aCBjdXJzb3Jfc2V0MiBhbmQgY3Vyc29yX3NldCwgcHJlZmVy IGNhbGxpbmcKPj4gdGhlIGxhdHRlciBmcm9tIHRoZSBkcm1fbW9kZV9jdXJzb3IgaW9jdGwuCj4+ Cj4+IFNpZ25lZC1vZmYtYnk6IFRob21hcyBIZWxsc3Ryb20gPHRoZWxsc3Ryb21Adm13YXJlLmNv bT4KPiBUaGF0IGxvb2tzIGxpa2UgcGFwZXJpbmcgb3ZlciBhIGJ1ZyBpbiB0aGUgY2xpZW50IC0g aXQgc2ltcGx5IHNob3VsZG4ndAo+IG1peCB0aGVzZSB0d28gaWYgaXQgZXhwZWN0cyB0aGUgaG90 c3BvdCB0byBzdGljayBhcm91bmQuIFRoZXJlIHdhcyBhbHNvCj4gcmVjZW50bHkgYSBiaWcgZGlz Y3Vzc2lvbiBhYm91dCBob3RzcG90IGJlaGF2aW91ciwgYW5kIHRoZSBjb25jbHVzaW9uIHdhcwo+ IHRoYXQgcXhsIGdvdCBpdCBhbGwgd3JvbmcuIFNpbmNlIHRoYXQgd2FzIHNwZWNpZmljYWxseSBh ZGRlZCBmb3IgcXhsIEknbQo+IG5vdCBzdXJlIGhvdyB3ZWxsIHRoaXMgd2FzIGV2ZXIgdGVzdGVk IC4uLgoKTm8sIHRoaXMgaXMgbm90IHRoZSBjYXNlLCBUaGlzIGlzIGZvciBvbGQgWG9yZyB1c2Vy c3BhY2UgdGhhdCBmaXJzdCBzZXRzCnRoZSBob3RzcG90IHVzaW5nIG91ciBhbmNpZW50CmRyaXZl ci1wcml2YXRlIGlvY3RsIGFuZCB0aGVuIGNhbGxzIGRybV9tb2RlX2N1cnNvcigpIHRvIHVwZGF0 ZSB0aGUgY3Vyc29yLgoKTm93IGlmIHdlIHdlcmUgdG8gaW1wbGVtZW50IGN1cnNvcl9zZXQyLCB3 aGljaCBpcyBhcHBhcmVudGx5IG5lZWRlZCB0bwpnZXQgZ25vbWUtc2hlbGwvV2F5bGFuZCBjdXJz b3JzIGluIHRoZSByaWdodCBwbGFjZSwgd2l0aG91dCB0aGlzIGZpeCwgaXQKd291bGQgYnJlYWsg b2xkIFhvcmcsIHNvIHdlIGRvbid0IGhhdmUgbXVjaCBjaG9pY2UgaW4gdGhpcyBjYXNlIGZyb20K d2hhdCBJIGNhbiB0ZWxsLgoKVGhlIHJvb3QgcHJvYmxlbSBoZXJlIGlzIHRoYXQgdGhlIGRybV9t b2RlX2N1cnNvcigpIGJlaGF2aW91ciBpbiB0aGUKcHJlc2VuY2Ugb2YgY3Vyc29yX3NldDIgZGlk bid0IHRha2UgdGhlIGV4aXN0aW5nIHZtd2FyZSBob3RzcG90CnNlbWFudGljcyBpbnRvIGFjY291 bnQuCgo+IFRoZSBvdGhlciBwcm9ibGVtIHNlZW1zIHRvIGJlIHRoYXQgWCBpcyByYWN5IHdpdGgg dXBkYXRpbmcgY3Vyc29ycyAoc2luY2UKPiBpdCBkb2VzIGEgc2V0UG9zIGFuZCBzZXRDdXJzb3Ig c2VwYXJhdGVseSwgZGVzcGl0ZSB0aGF0IHRoaXMgaW9jdGwgY2FuIGRvCj4gaXQgaW4gb25lIGdv KSBhbmQgc28gaWYgeW91IG1vdmUgdGhlIGhvdHNwb3QgeW91IGdldCBhIGp1bXB5IGN1cnNvci4K PiBSYWRlb24gdHJpZWQgdG8gcGFwZXIgb3ZlciB0aGF0IGJ1dCBmdW5kYW1lbnRhbGx5IHlvdSBu ZWVkIHRvIGZpeCBYIGFuZAo+IHVzZSBhdG9taWMgKG9yIGF0IGxlYXN0IHVuaXZlcnNhbCBwbGFu ZSBjdXJzb3Igc3VwcG9ydCkgdG8gZml4IHRoaXMuCj4KPiBHaXZlbiBhbGwgdGhhdCBJJ20gbGVh bmluZyB0b3dhcmRzICJ0aGUgZnV0dXJlIGlzIGF0b21pYyIsIGxldCdzIHBsZWFzZQo+IG5vdCBh ZGQgaGFja3MgdG8gbGVnYWN5IGNvZGUuIEFzaWRlOiBBdG9taWMgZG9lc24ndCBoYXZlIHRoZSBo b3RzcG90LXgveQo+IHByb3BlcnRpZXMgeWV0LCBidXQgcmVhbGx5IHRoZSBvbmx5IHJlYXNvbiB3 YXMgdGhhdCB3ZSBkb24ndCB5ZXQgaGF2ZSBhbgo+IGF0b21pYyBkcml2ZXIgbmVlZGluZyB0aGVt LiBBZGRpbmcgdGhvc2UgcHJvcHMgd2lsbCBiZSBhIHRpbnkgcGF0Y2ggb2YgYQo+IGZldyBsaW5l cy4KClNpbmNsYWlyIGhhcyBzdGFydGVkIHdvcmtpbmcgb24gYXRvbWljIHN1cHBvcnQgZm9yIHZt d2dmeCwgYnV0IHdlIHJlYWxseQpuZWVkIHRvIGZpeCB0aGlzIGFsc28gaW4KdGhlIGxlZ2FjeSBj b2RlLCB1Z2x5IG9yIG5vdC4KClRoYW5rcywKVGhvbWFzCgoKPgo+IENoZWVycywgRGFuaWVsCj4+ IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMgfCAxMCArKysrKystLS0tCj4+ICAx IGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2NydGMuYwo+PiBpbmRleCAyNGM1NDM0Li45M2Y4MGE1IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2NydGMuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+ PiBAQCAtMjg3NCw3ICsyODc0LDggQEAgc3RhdGljIGludCBkcm1fbW9kZV9jdXJzb3JfdW5pdmVy c2FsKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPj4gIAo+PiAgc3RhdGljIGludCBkcm1fbW9kZV9j dXJzb3JfY29tbW9uKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+ICAJCQkJICBzdHJ1Y3QgZHJt X21vZGVfY3Vyc29yMiAqcmVxLAo+PiAtCQkJCSAgc3RydWN0IGRybV9maWxlICpmaWxlX3ByaXYp Cj4+ICsJCQkJICBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdiwKPj4gKwkJCQkgIGJvb2wgZnJv bV8yKQo+PiAgewo+PiAgCXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPj4gIAlpbnQgcmV0ID0gMDsK Pj4gQEAgLTI5MDcsNyArMjkwOCw4IEBAIHN0YXRpYyBpbnQgZHJtX21vZGVfY3Vyc29yX2NvbW1v bihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+PiAgCQkJZ290byBvdXQ7Cj4+ICAJCX0KPj4gIAkJ LyogVHVybnMgb2ZmIHRoZSBjdXJzb3IgaWYgaGFuZGxlIGlzIDAgKi8KPj4gLQkJaWYgKGNydGMt PmZ1bmNzLT5jdXJzb3Jfc2V0MikKPj4gKwkJaWYgKGNydGMtPmZ1bmNzLT5jdXJzb3Jfc2V0MiAm Jgo+PiArCQkgICAgKGZyb21fMiB8fCAhY3J0Yy0+ZnVuY3MtPmN1cnNvcl9zZXQpKQo+PiAgCQkJ cmV0ID0gY3J0Yy0+ZnVuY3MtPmN1cnNvcl9zZXQyKGNydGMsIGZpbGVfcHJpdiwgcmVxLT5oYW5k bGUsCj4+ICAJCQkJCQkgICAgICByZXEtPndpZHRoLCByZXEtPmhlaWdodCwgcmVxLT5ob3RfeCwg cmVxLT5ob3RfeSk7Cj4+ICAJCWVsc2UKPj4gQEAgLTI5NTMsNyArMjk1NSw3IEBAIGludCBkcm1f bW9kZV9jdXJzb3JfaW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPj4gIAltZW1jcHkoJm5l d19yZXEsIHJlcSwgc2l6ZW9mKHN0cnVjdCBkcm1fbW9kZV9jdXJzb3IpKTsKPj4gIAluZXdfcmVx LmhvdF94ID0gbmV3X3JlcS5ob3RfeSA9IDA7Cj4+ICAKPj4gLQlyZXR1cm4gZHJtX21vZGVfY3Vy c29yX2NvbW1vbihkZXYsICZuZXdfcmVxLCBmaWxlX3ByaXYpOwo+PiArCXJldHVybiBkcm1fbW9k ZV9jdXJzb3JfY29tbW9uKGRldiwgJm5ld19yZXEsIGZpbGVfcHJpdiwgZmFsc2UpOwo+PiAgfQo+ PiAgCj4+ICAvKioKPj4gQEAgLTI5NzYsNyArMjk3OCw3IEBAIGludCBkcm1fbW9kZV9jdXJzb3Iy X2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+ICB7Cj4+ICAJc3RydWN0IGRybV9tb2Rl X2N1cnNvcjIgKnJlcSA9IGRhdGE7Cj4+ICAKPj4gLQlyZXR1cm4gZHJtX21vZGVfY3Vyc29yX2Nv bW1vbihkZXYsIHJlcSwgZmlsZV9wcml2KTsKPj4gKwlyZXR1cm4gZHJtX21vZGVfY3Vyc29yX2Nv bW1vbihkZXYsIHJlcSwgZmlsZV9wcml2LCB0cnVlKTsKPj4gIH0KPj4gIAo+PiAgLyoqCj4+IC0t IAo+PiAyLjQuMwo+Pgo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+PiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4+IGRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPj4gaHR0cHM6Ly91cmxkZWZlbnNlLnByb29mcG9pbnQuY29tL3YyL3VybD91 PWh0dHAtM0FfX2xpc3RzLmZyZWVkZXNrdG9wLm9yZ19tYWlsbWFuX2xpc3RpbmZvX2RyaS0yRGRl dmVsJmQ9QlFJQkFnJmM9U3FjbDBFejZNMFg4YWVNNjdMS0lpREpBWFZlQXctWWloVk1OdFh0LXVF cyZyPXZwdWtQa0J0cG9OUXAySVVLdUZ2aU9tUE5ZV1ZLbWVuM0plZXU1NXptRUEmbT1MdmFvV0tu ZVpCTXFvcXZvbm1OYnRyUTlzWTFkTDV1bkNHX0QyX1hiLS1ZJnM9SXBlbllrT2VPRlNNa0NCdk1w MV9URWFtNy1LZEZYNHpiZkNDOTQzR0MzTSZlPSAKCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo=