From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Hellstrom Subject: Re: [PATCH 1/2] drm: Avoid calling the cursor_set2 callback from the drm_mode_cursor ioctl Date: Fri, 27 Nov 2015 13:24:11 +0100 Message-ID: <56584B6B.7060302@vmware.com> References: <1448563935-3157-1-git-send-email-thellstrom@vmware.com> <20151127101133.GW17050@phenom.ffwll.local> <56584197.3020707@vmware.com> <20151127120248.GL4437@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp-outbound-1.vmware.com (smtp-outbound-1.vmware.com [208.91.2.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 322A07A15A for ; Fri, 27 Nov 2015 04:24:15 -0800 (PST) In-Reply-To: <20151127120248.GL4437@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: airlied@redhat.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gMTEvMjcvMjAxNSAwMTowMiBQTSwgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+IE9uIEZyaSwg Tm92IDI3LCAyMDE1IGF0IDEyOjQyOjE1UE0gKzAxMDAsIFRob21hcyBIZWxsc3Ryb20gd3JvdGU6 Cj4+IE9uIDExLzI3LzIwMTUgMTE6MTEgQU0sIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4+PiBPbiBU aHUsIE5vdiAyNiwgMjAxNSBhdCAxMDo1MjoxNEFNIC0wODAwLCBUaG9tYXMgSGVsbHN0cm9tIHdy b3RlOgo+Pj4+IElmIHRoZSBkcm1fbW9kZV9jdXJzb3JfaW9jdGwgaXMgY2FsbGVkIGFuZCB0aGUg Y3Vyc29yX3NldDIgY2FsbGJhY2sgaXMKPj4+PiBpbXBsZW1lbnRlZCwgdGhlIGN1cnNvciBob3Rz cG90IGlzIHNldCB0byAoMCwwKSB3aGljaCBpcyBpbmNvbXBhdGlibGUKPj4+PiB3aXRoIHZtd2dm eCB3aGVyZSB0aGUgaG90c3BvdCBzaG91bGQgaW5zdGVhZCByZW1haW4gdW5jaGFuZ2VkLgo+Pj4+ Cj4+Pj4gU28gaWYgdGhlIGRyaXZlciBpbXBsZW1lbnRzIGJvdGggY3Vyc29yX3NldDIgYW5kIGN1 cnNvcl9zZXQsIHByZWZlciBjYWxsaW5nCj4+Pj4gdGhlIGxhdHRlciBmcm9tIHRoZSBkcm1fbW9k ZV9jdXJzb3IgaW9jdGwuCj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBUaG9tYXMgSGVsbHN0cm9t IDx0aGVsbHN0cm9tQHZtd2FyZS5jb20+Cj4+PiBUaGF0IGxvb2tzIGxpa2UgcGFwZXJpbmcgb3Zl ciBhIGJ1ZyBpbiB0aGUgY2xpZW50IC0gaXQgc2ltcGx5IHNob3VsZG4ndAo+Pj4gbWl4IHRoZXNl IHR3byBpZiBpdCBleHBlY3RzIHRoZSBob3RzcG90IHRvIHN0aWNrIGFyb3VuZC4gVGhlcmUgd2Fz IGFsc28KPj4+IHJlY2VudGx5IGEgYmlnIGRpc2N1c3Npb24gYWJvdXQgaG90c3BvdCBiZWhhdmlv dXIsIGFuZCB0aGUgY29uY2x1c2lvbiB3YXMKPj4+IHRoYXQgcXhsIGdvdCBpdCBhbGwgd3Jvbmcu IFNpbmNlIHRoYXQgd2FzIHNwZWNpZmljYWxseSBhZGRlZCBmb3IgcXhsIEknbQo+Pj4gbm90IHN1 cmUgaG93IHdlbGwgdGhpcyB3YXMgZXZlciB0ZXN0ZWQgLi4uCj4+IE5vLCB0aGlzIGlzIG5vdCB0 aGUgY2FzZSwgVGhpcyBpcyBmb3Igb2xkIFhvcmcgdXNlcnNwYWNlIHRoYXQgZmlyc3Qgc2V0cwo+ PiB0aGUgaG90c3BvdCB1c2luZyBvdXIgYW5jaWVudAo+PiBkcml2ZXItcHJpdmF0ZSBpb2N0bCBh bmQgdGhlbiBjYWxscyBkcm1fbW9kZV9jdXJzb3IoKSB0byB1cGRhdGUgdGhlIGN1cnNvci4KPj4K Pj4gTm93IGlmIHdlIHdlcmUgdG8gaW1wbGVtZW50IGN1cnNvcl9zZXQyLCB3aGljaCBpcyBhcHBh cmVudGx5IG5lZWRlZCB0bwo+PiBnZXQgZ25vbWUtc2hlbGwvV2F5bGFuZCBjdXJzb3JzIGluIHRo ZSByaWdodCBwbGFjZSwgd2l0aG91dCB0aGlzIGZpeCwgaXQKPj4gd291bGQgYnJlYWsgb2xkIFhv cmcsIHNvIHdlIGRvbid0IGhhdmUgbXVjaCBjaG9pY2UgaW4gdGhpcyBjYXNlIGZyb20KPj4gd2hh dCBJIGNhbiB0ZWxsLgo+Pgo+PiBUaGUgcm9vdCBwcm9ibGVtIGhlcmUgaXMgdGhhdCB0aGUgZHJt X21vZGVfY3Vyc29yKCkgYmVoYXZpb3VyIGluIHRoZQo+PiBwcmVzZW5jZSBvZiBjdXJzb3Jfc2V0 MiBkaWRuJ3QgdGFrZSB0aGUgZXhpc3Rpbmcgdm13YXJlIGhvdHNwb3QKPj4gc2VtYW50aWNzIGlu dG8gYWNjb3VudC4KPj4KPj4+IFRoZSBvdGhlciBwcm9ibGVtIHNlZW1zIHRvIGJlIHRoYXQgWCBp cyByYWN5IHdpdGggdXBkYXRpbmcgY3Vyc29ycyAoc2luY2UKPj4+IGl0IGRvZXMgYSBzZXRQb3Mg YW5kIHNldEN1cnNvciBzZXBhcmF0ZWx5LCBkZXNwaXRlIHRoYXQgdGhpcyBpb2N0bCBjYW4gZG8K Pj4+IGl0IGluIG9uZSBnbykgYW5kIHNvIGlmIHlvdSBtb3ZlIHRoZSBob3RzcG90IHlvdSBnZXQg YSBqdW1weSBjdXJzb3IuCj4+PiBSYWRlb24gdHJpZWQgdG8gcGFwZXIgb3ZlciB0aGF0IGJ1dCBm dW5kYW1lbnRhbGx5IHlvdSBuZWVkIHRvIGZpeCBYIGFuZAo+Pj4gdXNlIGF0b21pYyAob3IgYXQg bGVhc3QgdW5pdmVyc2FsIHBsYW5lIGN1cnNvciBzdXBwb3J0KSB0byBmaXggdGhpcy4KPj4+Cj4+ PiBHaXZlbiBhbGwgdGhhdCBJJ20gbGVhbmluZyB0b3dhcmRzICJ0aGUgZnV0dXJlIGlzIGF0b21p YyIsIGxldCdzIHBsZWFzZQo+Pj4gbm90IGFkZCBoYWNrcyB0byBsZWdhY3kgY29kZS4gQXNpZGU6 IEF0b21pYyBkb2Vzbid0IGhhdmUgdGhlIGhvdHNwb3QteC95Cj4+PiBwcm9wZXJ0aWVzIHlldCwg YnV0IHJlYWxseSB0aGUgb25seSByZWFzb24gd2FzIHRoYXQgd2UgZG9uJ3QgeWV0IGhhdmUgYW4K Pj4+IGF0b21pYyBkcml2ZXIgbmVlZGluZyB0aGVtLiBBZGRpbmcgdGhvc2UgcHJvcHMgd2lsbCBi ZSBhIHRpbnkgcGF0Y2ggb2YgYQo+Pj4gZmV3IGxpbmVzLgo+PiBTaW5jbGFpciBoYXMgc3RhcnRl ZCB3b3JraW5nIG9uIGF0b21pYyBzdXBwb3J0IGZvciB2bXdnZngsIGJ1dCB3ZSByZWFsbHkKPj4g bmVlZCB0byBmaXggdGhpcyBhbHNvIGluCj4+IHRoZSBsZWdhY3kgY29kZSwgdWdseSBvciBub3Qu Cj4gSSB3YXMgdGhpbmtpbmcgbWF5YmUgaXQgd291bGQgYmUgY2xlYW5lciB0byBub3QgcmVzZXQg dGhlIGhvdHNwb3QgdG8KPiAwLDAgaW4gZHJtX21vZGVfY3Vyc29yX2lvY3RsKCkgYW5kIGluc3Rl YWQga2VlcCB3aGF0IHdhcyBwcmV2aW91c2x5Cj4gY29uZmlndXJlZCwgYW5kIG9ubHkgZG8gdGhl IHJlc2V0IHRvIDAsMCBpbiBsYXN0Y2xvc2UgKG9yIHNvbWUgb3RoZXIKPiBzdWl0YWJsZSBwbGFj ZSk/IEJ1dCBJIHN1cHBvc2UgdGhhdCBjb3VsZCBicmVhayBzb21ldGhpbmcgZWxzZSB0aGF0Cj4g YXNzdW1lIHRoYXQgZHJtX21vZGVfY3Vyc29yX2lvY3RsKCkgd2lsbCBkbyB0aGUgcmVzZXQuCgpJ ZiBzb21ldGhpbmcgYXNzdW1lcyB0aGF0IGRybV9tb2RlX2N1cnNvcl9pb2N0bCgpIHdpbGwgcmVz ZXQgdGhlCmhvdHNwb3QsIHRoZW4gd2UncmUgYWxyZWFkeSBpbiB0cm91YmxlIGJlY2F1c2UgdGhl biB3ZSBoYXZlIGRpZmZlcmVudApzZW1hbnRpY3Mgb2YgdGhlIHNhbWUgaW9jdGwgYXNzdW1lZCBi eSB1c2VyLXNwYWNlLgoKSG93ZXZlciwgZnJvbSB3aGF0IEkgY2FuIHRlbGwsIGdldHRpbmcgdGhl IGN1cnNvciBob3RzcG90IHBvc2l0aW9uIGZyb20Kd2l0aGluIGNvcmUgRFJNIHdvdWxkIHJlcXVp cmUgbmV3IGxvY2sgcHJvdGVjdGVkIGhvdHNwb3QgY29vcmRpbmF0ZQptZW1iZXJzIGluIHRoZSBj cnRjIHN0cnVjdHVyZS4uLgoKL1Rob21hcwoKCgoKCgoKPgo+PiBUaGFua3MsCj4+IFRob21hcwo+ Pgo+Pgo+Pj4gQ2hlZXJzLCBEYW5pZWwKPj4+PiAtLS0KPj4+PiAgZHJpdmVycy9ncHUvZHJtL2Ry bV9jcnRjLmMgfCAxMCArKysrKystLS0tCj4+Pj4gIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlv bnMoKyksIDQgZGVsZXRpb25zKC0pCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2RybV9jcnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+Pj4+IGluZGV4IDI0 YzU0MzQuLjkzZjgwYTUgMTAwNjQ0Cj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRj LmMKPj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+Pj4+IEBAIC0yODc0LDcg KzI4NzQsOCBAQCBzdGF0aWMgaW50IGRybV9tb2RlX2N1cnNvcl91bml2ZXJzYWwoc3RydWN0IGRy bV9jcnRjICpjcnRjLAo+Pj4+ICAKPj4+PiAgc3RhdGljIGludCBkcm1fbW9kZV9jdXJzb3JfY29t bW9uKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+Pj4gIAkJCQkgIHN0cnVjdCBkcm1fbW9kZV9j dXJzb3IyICpyZXEsCj4+Pj4gLQkJCQkgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZV9wcml2KQo+Pj4+ ICsJCQkJICBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdiwKPj4+PiArCQkJCSAgYm9vbCBmcm9t XzIpCj4+Pj4gIHsKPj4+PiAgCXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPj4+PiAgCWludCByZXQg PSAwOwo+Pj4+IEBAIC0yOTA3LDcgKzI5MDgsOCBAQCBzdGF0aWMgaW50IGRybV9tb2RlX2N1cnNv cl9jb21tb24oc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPj4+PiAgCQkJZ290byBvdXQ7Cj4+Pj4g IAkJfQo+Pj4+ICAJCS8qIFR1cm5zIG9mZiB0aGUgY3Vyc29yIGlmIGhhbmRsZSBpcyAwICovCj4+ Pj4gLQkJaWYgKGNydGMtPmZ1bmNzLT5jdXJzb3Jfc2V0MikKPj4+PiArCQlpZiAoY3J0Yy0+ZnVu Y3MtPmN1cnNvcl9zZXQyICYmCj4+Pj4gKwkJICAgIChmcm9tXzIgfHwgIWNydGMtPmZ1bmNzLT5j dXJzb3Jfc2V0KSkKPj4+PiAgCQkJcmV0ID0gY3J0Yy0+ZnVuY3MtPmN1cnNvcl9zZXQyKGNydGMs IGZpbGVfcHJpdiwgcmVxLT5oYW5kbGUsCj4+Pj4gIAkJCQkJCSAgICAgIHJlcS0+d2lkdGgsIHJl cS0+aGVpZ2h0LCByZXEtPmhvdF94LCByZXEtPmhvdF95KTsKPj4+PiAgCQllbHNlCj4+Pj4gQEAg LTI5NTMsNyArMjk1NSw3IEBAIGludCBkcm1fbW9kZV9jdXJzb3JfaW9jdGwoc3RydWN0IGRybV9k ZXZpY2UgKmRldiwKPj4+PiAgCW1lbWNweSgmbmV3X3JlcSwgcmVxLCBzaXplb2Yoc3RydWN0IGRy bV9tb2RlX2N1cnNvcikpOwo+Pj4+ICAJbmV3X3JlcS5ob3RfeCA9IG5ld19yZXEuaG90X3kgPSAw Owo+Pj4+ICAKPj4+PiAtCXJldHVybiBkcm1fbW9kZV9jdXJzb3JfY29tbW9uKGRldiwgJm5ld19y ZXEsIGZpbGVfcHJpdik7Cj4+Pj4gKwlyZXR1cm4gZHJtX21vZGVfY3Vyc29yX2NvbW1vbihkZXYs ICZuZXdfcmVxLCBmaWxlX3ByaXYsIGZhbHNlKTsKPj4+PiAgfQo+Pj4+ICAKPj4+PiAgLyoqCj4+ Pj4gQEAgLTI5NzYsNyArMjk3OCw3IEBAIGludCBkcm1fbW9kZV9jdXJzb3IyX2lvY3RsKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsCj4+Pj4gIHsKPj4+PiAgCXN0cnVjdCBkcm1fbW9kZV9jdXJzb3Iy ICpyZXEgPSBkYXRhOwo+Pj4+ICAKPj4+PiAtCXJldHVybiBkcm1fbW9kZV9jdXJzb3JfY29tbW9u KGRldiwgcmVxLCBmaWxlX3ByaXYpOwo+Pj4+ICsJcmV0dXJuIGRybV9tb2RlX2N1cnNvcl9jb21t b24oZGV2LCByZXEsIGZpbGVfcHJpdiwgdHJ1ZSk7Cj4+Pj4gIH0KPj4+PiAgCj4+Pj4gIC8qKgo+ Pj4+IC0tIAo+Pj4+IDIuNC4zCj4+Pj4KPj4+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwo+Pj4+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPj4+PiBkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+Pj4gaHR0cHM6Ly91cmxkZWZlbnNlLnByb29m cG9pbnQuY29tL3YyL3VybD91PWh0dHAtM0FfX2xpc3RzLmZyZWVkZXNrdG9wLm9yZ19tYWlsbWFu X2xpc3RpbmZvX2RyaS0yRGRldmVsJmQ9QlFJQkFnJmM9U3FjbDBFejZNMFg4YWVNNjdMS0lpREpB WFZlQXctWWloVk1OdFh0LXVFcyZyPXZwdWtQa0J0cG9OUXAySVVLdUZ2aU9tUE5ZV1ZLbWVuM0pl ZXU1NXptRUEmbT1MdmFvV0tuZVpCTXFvcXZvbm1OYnRyUTlzWTFkTDV1bkNHX0QyX1hiLS1ZJnM9 SXBlbllrT2VPRlNNa0NCdk1wMV9URWFtNy1LZEZYNHpiZkNDOTQzR0MzTSZlPSAKPj4KPj4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPj4gZHJpLWRldmVs IG1haWxpbmcgbGlzdAo+PiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHBz Oi8vdXJsZGVmZW5zZS5wcm9vZnBvaW50LmNvbS92Mi91cmw/dT1odHRwLTNBX19saXN0cy5mcmVl ZGVza3RvcC5vcmdfbWFpbG1hbl9saXN0aW5mb19kcmktMkRkZXZlbCZkPUJRSURBdyZjPVNxY2ww RXo2TTBYOGFlTTY3TEtJaURKQVhWZUF3LVlpaFZNTnRYdC11RXMmcj12cHVrUGtCdHBvTlFwMklV S3VGdmlPbVBOWVdWS21lbjNKZWV1NTV6bUVBJm09bHdrZ0VDeTYtY0lPTDQ4LXBWNHM1dXJLQUpq NG9YYTVYSlR6MmQ3dzJsVSZzPTNLcE9jVmtlMEdQaU1jbUhCVE12eEhlMFNwVUJNeEZfRDNBNzZP aFJYdEUmZT0gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK