From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Huaitong Han <huaitong.han@intel.com>
Cc: jbeulich@suse.com, xen-devel@lists.xen.org
Subject: Re: [V2 PATCH 0/9] x86/hvm: pkeys, add memory protection-key support
Date: Fri, 27 Nov 2015 12:59:19 +0000 [thread overview]
Message-ID: <565853A7.4000105@citrix.com> (raw)
In-Reply-To: <1448617923-10884-1-git-send-email-huaitong.han@intel.com>
On 27/11/15 09:51, Huaitong Han wrote:
> Changes in v2:
> *Rebase all patches in staging branch
> *Disable X86_CR4_PKE on hypervisor, and delete pkru_read/write functions, and
> use xsave state read to get pkru value.
> *Delete the patch that adds pkeys support for do_page_fault.
> *Add pkeys support for gva2gfn so that setting _PAGE_PK_BIT in the return
> value can get propagated to the guest correctly.
>
> The protection-key feature provides an additional mechanism by which IA-32e
> paging controls access to usermode addresses.
>
> Hardware support for protection keys for user pages is enumerated with CPUID
> feature flag CPUID.7.0.ECX[3]:PKU. Software support is CPUID.7.0.ECX[4]:OSPKE
> with the setting of CR4.PKE(bit 22).
>
> When CR4.PKE = 1, every linear address is associated with the 4-bit protection
> key located in bits 62:59 of the paging-structure entry that mapped the page
> containing the linear address. The PKRU register determines, for each
> protection key, whether user-mode addresses with that protection key may be
> read or written.
>
> The PKRU register (protection key rights for user pages) is a 32-bit register
> with the following format: for each i (0 ≤ i ≤ 15), PKRU[2i] is the
> access-disable bit for protection key i (ADi); PKRU[2i+1] is the write-disable
> bit for protection key i (WDi).
>
> Software can use the RDPKRU and WRPKRU instructions with ECX = 0 to read and
> write PKRU. In addition, the PKRU register is XSAVE-managed state and can thus
> be read and written by instructions in the XSAVE feature set.
>
> PFEC.PK (bit 5) is defined as protection key violations.
>
> The specification of Protection Keys can be found at SDM (4.6.2, volume 3)
> http://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-architectures-software-developer-manual-325462.pdf.
Just for my own understand, do you have a sample use-case for protection
keys?
As everything can WRPKRU, I cant see how it would actually be useful.
Clearly there is a usecase or you (Intel) wouldn't have gone to the
effort of putting into silicon.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-11-27 12:59 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 9:51 [V2 PATCH 0/9] x86/hvm: pkeys, add memory protection-key support Huaitong Han
2015-11-27 9:51 ` [V2 PATCH 1/9] x86/hvm: pkeys, add pkeys support for cpuid handling Huaitong Han
2015-12-01 20:03 ` Andrew Cooper
2015-12-02 11:06 ` Jan Beulich
2015-12-03 1:53 ` Han, Huaitong
2015-12-03 10:41 ` Jan Beulich
2015-12-02 11:19 ` Jan Beulich
2015-11-27 9:51 ` [V2 PATCH 2/9] x86/hvm: pkeys, add the flag to enable Memory Protection Keys Huaitong Han
2015-12-01 20:04 ` Andrew Cooper
2015-12-02 11:21 ` Jan Beulich
2015-11-27 9:51 ` [V2 PATCH 3/9] x86/hvm: pkeys, add pkeys support when setting CR4 Huaitong Han
2015-12-01 20:05 ` Andrew Cooper
2015-11-27 9:51 ` [V2 PATCH 4/9] x86/hvm: pkeys, disable pkeys for guests in non-paging mode Huaitong Han
2015-11-27 9:51 ` [V2 PATCH 5/9] x86/hvm: pkeys, add functions to get pkeys value from PTE Huaitong Han
2015-12-01 20:11 ` Andrew Cooper
2015-12-02 11:24 ` Jan Beulich
2015-11-27 9:52 ` [V2 PATCH 6/9] x86/hvm: pkeys, add functions to support PKRU access Huaitong Han
2015-12-01 20:12 ` Andrew Cooper
2015-11-27 9:52 ` [V2 PATCH 7/9] x86/hvm: pkeys, add pkeys support for guest_walk_tables Huaitong Han
2015-12-01 20:30 ` Andrew Cooper
2015-12-02 8:23 ` Han, Huaitong
2015-12-02 11:14 ` Jan Beulich
2015-12-02 11:16 ` Jan Beulich
2015-12-02 11:29 ` Jan Beulich
2015-11-27 9:52 ` [V2 PATCH 8/9] x86/hvm: pkeys, add xstate support for pkeys Huaitong Han
2015-12-01 20:43 ` Andrew Cooper
2015-12-02 7:20 ` Han, Huaitong
2015-12-02 11:31 ` Jan Beulich
2015-12-03 1:58 ` Han, Huaitong
2015-12-03 10:42 ` Jan Beulich
2015-12-03 10:56 ` Andrew Cooper
2015-11-27 9:52 ` [V2 PATCH 9/9] x86/hvm: pkeys, add pkeys support for gva2gfn funcitons Huaitong Han
2015-12-02 11:35 ` Jan Beulich
2015-12-03 8:50 ` Han, Huaitong
2015-12-03 10:47 ` Jan Beulich
2015-11-27 12:59 ` Andrew Cooper [this message]
2015-11-27 16:22 ` [V2 PATCH 0/9] x86/hvm: pkeys, add memory protection-key support Han, Huaitong
2015-11-27 16:31 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565853A7.4000105@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=huaitong.han@intel.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.