From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86/HVM: XSETBV intercept needs to check CPL on SVM only Date: Fri, 27 Nov 2015 13:21:09 +0000 Message-ID: <565858C5.1060002@citrix.com> References: <5658463602000078000B9A0D@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a2Ixe-0001ZU-In for xen-devel@lists.xenproject.org; Fri, 27 Nov 2015 13:21:14 +0000 In-Reply-To: <5658463602000078000B9A0D@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Kevin Tian , Keir Fraser , Suravee Suthikulpanit , Aravind Gopalakrishnan , Jun Nakajima , Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org On 27/11/15 11:01, Jan Beulich wrote: > VMX doesn't need a software CPL check on the XSETBV intercept, and > SVM can do that check without resorting to hvm_get_segment_register(). > > Clean up what is left of hvm_handle_xsetbv(), namely make it return a > proper error code. > > Signed-off-by: Jan Beulich Your statement matches the statement in the manual. Reviewed-by: Andrew Cooper