From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v9 9/9] libxl: add support for migrating HVM guests without a device model Date: Fri, 27 Nov 2015 13:55:20 +0000 Message-ID: <565860C8.6020901@citrix.com> References: <1448631785-11402-1-git-send-email-roger.pau@citrix.com> <1448631785-11402-10-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a2JUj-0004Ng-Ir for xen-devel@lists.xenproject.org; Fri, 27 Nov 2015 13:55:25 +0000 In-Reply-To: <1448631785-11402-10-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 27/11/15 13:43, Roger Pau Monne wrote: > diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h > index 7e8054a..d6cb63d 100644 > --- a/tools/libxl/libxl_internal.h > +++ b/tools/libxl/libxl_internal.h > @@ -3036,6 +3036,9 @@ struct libxl__stream_write_state { > libxl__datacopier_state dc; > sws_record_done_cb record_done_callback; > > + /* Cache device model version. */ > + int device_model_version; > + Please put an initialiser in libxl__stream_write_init(). With that done, Reviewed-by: Andrew Cooper