From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86/PV: hide features dependent on XSAVE when booted with "no-xsave"
Date: Fri, 27 Nov 2015 15:05:45 +0000 [thread overview]
Message-ID: <56587149.6010909@citrix.com> (raw)
In-Reply-To: <5658471802000078000B9A27@prv-mh.provo.novell.com>
On 27/11/15 11:05, Jan Beulich wrote:
> ... or when the guest has the XSAVE feature hidden by CPUID policy.
> Not doing so is at best confusing to guests.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
These changes here are an improvement (so I don't object to taking them
ahead of my fullblown levelling series), but they are incomplete.
xsaveopt, xsavec, xsetbv1, xsaves, avx and mpx depend on xsave.
fma, fma4, f16c, avx2 and xop depend on avx.
My levelling series actually introduces a dependency tree to properly
evaluate the knockon effects of disabling certain features. I am unsure
whether it is worth your time to split xsave and avx here, but I
certainly wouldn't recommend making it any finer-grained at this stage.
~Andrew
next prev parent reply other threads:[~2015-11-27 15:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 11:05 [PATCH] x86/PV: hide features dependent on XSAVE when booted with "no-xsave" Jan Beulich
2015-11-27 15:05 ` Andrew Cooper [this message]
2015-11-30 10:01 ` Jan Beulich
2015-11-30 10:46 ` Andrew Cooper
2015-11-30 11:08 ` Jan Beulich
2015-11-30 11:10 ` Andrew Cooper
2015-11-30 11:30 ` Jan Beulich
2015-11-30 13:36 ` Andrew Cooper
2015-11-30 15:22 ` Jan Beulich
2015-11-30 15:38 ` Andrew Cooper
2015-11-30 16:00 ` Jan Beulich
2015-11-30 18:01 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56587149.6010909@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.