From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] rpi-userland: fix musl compile
Date: Fri, 27 Nov 2015 21:50:58 +0100 [thread overview]
Message-ID: <5658C232.9030600@mind.be> (raw)
In-Reply-To: <1448645857-14999-1-git-send-email-sergio.prado@e-labworks.com>
Hi Sergio,
On 27-11-15 18:37, Sergio Prado wrote:
> When building with musl, the build fails with a conflicting type
> qualifier error.
>
> This is because musl defines stdout and stderr as const pointers
> and RaspiVidYUV.c adds an extern declaration as normal pointers.
>
> Since this declaration already comes in on the header (stdio.h),
> there is no need to add an extern declaration, so removes it.
>
> Fixes:
>
> http://autobuild.buildroot.net/results/27bd6f32cecdb4e7c95247c1feaf2732c1d8e3fa
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
> ---
> ...ting-type-qualifiers-errors-when-building.patch | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 package/rpi-userland/0006-Fix-conflicting-type-qualifiers-errors-when-building.patch
>
> diff --git a/package/rpi-userland/0006-Fix-conflicting-type-qualifiers-errors-when-building.patch b/package/rpi-userland/0006-Fix-conflicting-type-qualifiers-errors-when-building.patch
> new file mode 100644
> index 000000000000..4db60142c6ad
> --- /dev/null
> +++ b/package/rpi-userland/0006-Fix-conflicting-type-qualifiers-errors-when-building.patch
> @@ -0,0 +1,23 @@
> +Fix conflicting type qualifiers errors when building with musl.
> +
> +Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
Did you send this patch upstream?
Regards,
Arnout
> +---
> + host_applications/linux/apps/raspicam/RaspiVidYUV.c | 2 --
> + 1 file changed, 2 deletions(-)
> +
> +diff --git a/host_applications/linux/apps/raspicam/RaspiVidYUV.c b/host_applications/linux/apps/raspicam/RaspiVidYUV.c
> +index b340d63c913f..13e6a6ccf5bf 100644
> +--- a/host_applications/linux/apps/raspicam/RaspiVidYUV.c
> ++++ b/host_applications/linux/apps/raspicam/RaspiVidYUV.c
> +@@ -106,8 +106,6 @@ const int ABORT_INTERVAL = 100; // ms
> + /// Run/record forever
> + #define WAIT_METHOD_FOREVER 4
> +
> +-extern FILE *stderr, *stdout;
> +-
> + int mmal_status_to_int(MMAL_STATUS_T status);
> + static void signal_handler(int signal_number);
> +
> +--
> +1.9.1
> +
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2015-11-27 20:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 17:37 [Buildroot] [PATCH] rpi-userland: fix musl compile Sergio Prado
2015-11-27 18:30 ` Peter Korsgaard
2015-11-27 20:50 ` Arnout Vandecappelle [this message]
2015-11-27 21:31 ` Sergio Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5658C232.9030600@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.