From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Felipe Balbi <balbi@ti.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] usb: musb: convert printk to pr_*
Date: Sat, 28 Nov 2015 13:21:47 +0300 [thread overview]
Message-ID: <5659803B.60807@cogentembedded.com> (raw)
In-Reply-To: <20151128000432.GA22297@kroah.com>
On 11/28/2015 3:04 AM, Greg Kroah-Hartman wrote:
>>> This file already uses pr_debug in a few places; this converts the
>>> remaining printks.
>>
>> Are you aware that printk(KERN_DEBUG, ...) and pr_debug() are not equivalent?
>
> Yes, and that is a good thing, you should be using pr_debug() instead of
> printk(KERN_DEBUG...).
>
> Why object to something like this?
I'm not objecting, just asking. There have been many cases in my practice
where a patch author wasn't aware of that...
It's just that these printk()'s could have been intentional (not to depend
on DEBUG or dynamic debugging).
> greg k-h
MBR, Sergei
next prev parent reply other threads:[~2015-11-28 10:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 10:38 [PATCH 1/3] usb: musb: convert printk to pr_* Rasmus Villemoes
2015-11-27 10:38 ` [PATCH 2/3] usb: musb: remove always-empty string from debug output Rasmus Villemoes
2015-11-27 10:38 ` [PATCH 3/3] usb: musb: remove redundant stack buffer Rasmus Villemoes
2015-12-01 15:00 ` Felipe Balbi
2015-12-03 9:31 ` Rasmus Villemoes
2015-11-27 12:23 ` [PATCH 1/3] usb: musb: convert printk to pr_* Sergei Shtylyov
2015-11-28 0:04 ` Greg Kroah-Hartman
2015-11-28 10:21 ` Sergei Shtylyov [this message]
2015-11-30 20:48 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5659803B.60807@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.