From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>, ciara.loftus@intel.com
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>,
ktraynor@redhat.com, gaetan.rivet@6wind.com,
jblunck@infradead.org
Subject: Re: [PATCH] ethdev: revert use device name from device structure
Date: Wed, 11 Oct 2017 23:56:54 +0200 [thread overview]
Message-ID: <5659846.3hnuzHVyBs@xps> (raw)
In-Reply-To: <20170922145722.GA3871@6wind.com>
22/09/2017 16:57, Adrien Mazarguil:
> On Fri, Sep 22, 2017 at 12:30:07PM +0100, Ferruh Yigit wrote:
> > This reverts commit a1e7c17555e8f77d520ba5f06ed26c00e77a2bd1.
> >
> > Original commit assumes there is 1:1 mapping between physical device and
> > ethdev port, so that device name can be used per port instead of ethdev
> > name field.
> >
> > But one physical device may have multiple ethdev ports and each port
> > needs its own unique name.
> >
> > One issue reported here:
> > http://dpdk.org/ml/archives/users/2017-September/002484.html
> >
> > So reverting back the commit to continue using ethdev name field per
> > port.
> >
> > Reported-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
I agree we must keep separate the device name and the ethdev port name.
About the OVS issue (Cc'ing people), it would be valuable to work
in DPDK to establish a reliable syntax to describe a device
or a port. This is what we call devargs ; it is still a work in progress.
next prev parent reply other threads:[~2017-10-11 21:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 11:30 [PATCH] ethdev: revert use device name from device structure Ferruh Yigit
2017-09-22 14:57 ` Adrien Mazarguil
2017-10-11 21:56 ` Thomas Monjalon [this message]
2017-10-11 22:44 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5659846.3hnuzHVyBs@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=jblunck@infradead.org \
--cc=ktraynor@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.