All of lore.kernel.org
 help / color / mirror / Atom feed
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: dt: mvebu: ix4-300d: remove whole flash partition
Date: Sat, 28 Nov 2015 18:38:15 +0100	[thread overview]
Message-ID: <5659E687.9090502@gmail.com> (raw)
In-Reply-To: <20151128165258.GG32356@lunn.ch>

On 28.11.2015 17:52, Andrew Lunn wrote:
> On Sat, Nov 28, 2015 at 12:14:05PM +0100, Sebastian Hesselbarth wrote:
>> Current NAND node has an additional flash partition for the whole
>> flash overlapping with real partitions. Remove this partition as
>> the whole flash is already represented by the NAND device itself.
> 
> If i remember correctly, we discussed this when the contribution was
> made. I think the stock firmware might use this for applying updates.
> Maybe Benoit can comment?

Yes, please.

> If so, removing this will break compatibility with stock firmware. Do
> we want to do that? There are a few other mvebu dts files with a
> partition spanning the whole flash. Should we remove them as well?

Well, there is already a mtd device that spans the whole flash so
what is the purpose of another "partition" that isn't a part but
all of the device? Actually, I doubt that a FW update will wipe
the flash as a whole, i.e. including boot loader, boot env, user
config.

Anyway, let's see if Benoit can shed some light on this.

FWIW, neither single partitions nor a combined partitions node
should be a direct sub-node of the _controller_ but a NAND
_device_ node instead. Luckily, multi-device systems are not that
common, so I guess we wait with it until such a system pops up for
testing.

Sebastian

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
	Gregory Clement
	<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	Benoit Masson <yahoo-+V3Jd3LB6RBWk0Htik3J/w@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/4] ARM: dt: mvebu: ix4-300d: remove whole flash partition
Date: Sat, 28 Nov 2015 18:38:15 +0100	[thread overview]
Message-ID: <5659E687.9090502@gmail.com> (raw)
In-Reply-To: <20151128165258.GG32356-g2DYL2Zd6BY@public.gmane.org>

On 28.11.2015 17:52, Andrew Lunn wrote:
> On Sat, Nov 28, 2015 at 12:14:05PM +0100, Sebastian Hesselbarth wrote:
>> Current NAND node has an additional flash partition for the whole
>> flash overlapping with real partitions. Remove this partition as
>> the whole flash is already represented by the NAND device itself.
> 
> If i remember correctly, we discussed this when the contribution was
> made. I think the stock firmware might use this for applying updates.
> Maybe Benoit can comment?

Yes, please.

> If so, removing this will break compatibility with stock firmware. Do
> we want to do that? There are a few other mvebu dts files with a
> partition spanning the whole flash. Should we remove them as well?

Well, there is already a mtd device that spans the whole flash so
what is the purpose of another "partition" that isn't a part but
all of the device? Actually, I doubt that a FW update will wipe
the flash as a whole, i.e. including boot loader, boot env, user
config.

Anyway, let's see if Benoit can shed some light on this.

FWIW, neither single partitions nor a combined partitions node
should be a direct sub-node of the _controller_ but a NAND
_device_ node instead. Luckily, multi-device systems are not that
common, so I guess we wait with it until such a system pops up for
testing.

Sebastian


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jason Cooper <jason@lakedaemon.net>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>,
	Benoit Masson <yahoo@perenite.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ARM: dt: mvebu: ix4-300d: remove whole flash partition
Date: Sat, 28 Nov 2015 18:38:15 +0100	[thread overview]
Message-ID: <5659E687.9090502@gmail.com> (raw)
In-Reply-To: <20151128165258.GG32356@lunn.ch>

On 28.11.2015 17:52, Andrew Lunn wrote:
> On Sat, Nov 28, 2015 at 12:14:05PM +0100, Sebastian Hesselbarth wrote:
>> Current NAND node has an additional flash partition for the whole
>> flash overlapping with real partitions. Remove this partition as
>> the whole flash is already represented by the NAND device itself.
> 
> If i remember correctly, we discussed this when the contribution was
> made. I think the stock firmware might use this for applying updates.
> Maybe Benoit can comment?

Yes, please.

> If so, removing this will break compatibility with stock firmware. Do
> we want to do that? There are a few other mvebu dts files with a
> partition spanning the whole flash. Should we remove them as well?

Well, there is already a mtd device that spans the whole flash so
what is the purpose of another "partition" that isn't a part but
all of the device? Actually, I doubt that a FW update will wipe
the flash as a whole, i.e. including boot loader, boot env, user
config.

Anyway, let's see if Benoit can shed some light on this.

FWIW, neither single partitions nor a combined partitions node
should be a direct sub-node of the _controller_ but a NAND
_device_ node instead. Luckily, multi-device systems are not that
common, so I guess we wait with it until such a system pops up for
testing.

Sebastian



  reply	other threads:[~2015-11-28 17:38 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-28 11:14 [PATCH 0/4] ARM: dt: mvebu: ix4-300d: NAND cleanup and ECC Sebastian Hesselbarth
2015-11-28 11:14 ` Sebastian Hesselbarth
2015-11-28 11:14 ` [PATCH 1/4] ARM: dt: mvebu: ix4-300d: remove whole flash partition Sebastian Hesselbarth
2015-11-28 11:14   ` Sebastian Hesselbarth
2015-11-28 11:14   ` Sebastian Hesselbarth
2015-11-28 16:52   ` Andrew Lunn
2015-11-28 16:52     ` Andrew Lunn
2015-11-28 16:52     ` Andrew Lunn
2015-11-28 17:38     ` Sebastian Hesselbarth [this message]
2015-11-28 17:38       ` Sebastian Hesselbarth
2015-11-28 17:38       ` Sebastian Hesselbarth
2015-11-28 20:32       ` Benoit Masson
2015-11-28 20:32         ` Benoit Masson
2015-11-28 20:32         ` Benoit Masson
2015-11-28 21:11   ` Andrew Lunn
2015-11-28 21:11     ` Andrew Lunn
2015-11-30 14:16     ` Gregory CLEMENT
2015-11-30 14:16       ` Gregory CLEMENT
2015-11-28 11:14 ` [PATCH 2/4] ARM: dt: mvebu: ix4-300d: move partitions to partition sub-node Sebastian Hesselbarth
2015-11-28 11:14   ` Sebastian Hesselbarth
2015-11-28 17:00   ` Andrew Lunn
2015-11-28 17:00     ` Andrew Lunn
2015-11-28 17:00     ` Andrew Lunn
2015-11-28 17:38     ` Sebastian Hesselbarth
2015-11-28 17:38       ` Sebastian Hesselbarth
2015-11-30 14:17   ` Gregory CLEMENT
2015-11-30 14:17     ` Gregory CLEMENT
2015-11-28 11:14 ` [PATCH 3/4] ARM: dt: mvebu: ix4-300d: Cleanup NAND partition ranges Sebastian Hesselbarth
2015-11-28 11:14   ` Sebastian Hesselbarth
2015-11-28 17:01   ` Andrew Lunn
2015-11-28 17:01     ` Andrew Lunn
2015-11-28 17:01     ` Andrew Lunn
2015-11-30 14:20     ` Gregory CLEMENT
2015-11-30 14:20       ` Gregory CLEMENT
2015-11-30 14:20       ` Gregory CLEMENT
2015-11-28 11:14 ` [PATCH 4/4] ARM: dt: mvebu: ix4-300d: Add ECC properties to NAND flash Sebastian Hesselbarth
2015-11-28 11:14   ` Sebastian Hesselbarth
2015-11-28 17:02   ` Andrew Lunn
2015-11-28 17:02     ` Andrew Lunn
2015-11-28 17:02     ` Andrew Lunn
2015-11-29 14:35   ` Thomas Petazzoni
2015-11-29 14:35     ` Thomas Petazzoni
2015-11-29 14:35     ` Thomas Petazzoni
2015-11-30  8:30     ` Sebastian Hesselbarth
2015-11-30  8:30       ` Sebastian Hesselbarth
2015-11-30  8:30       ` Sebastian Hesselbarth
2015-11-30 14:22       ` Gregory CLEMENT
2015-11-30 14:22         ` Gregory CLEMENT
2015-11-30 14:22         ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5659E687.9090502@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.