All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joao Eduardo Luis <joao@suse.de>
To: Loic Dachary <loic@dachary.org>,
	Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: RFC: teuthology field in commit messages
Date: Sun, 29 Nov 2015 11:51:27 +0000	[thread overview]
Message-ID: <565AE6BF.4040701@suse.de> (raw)
In-Reply-To: <5659CE92.4000203@dachary.org>

On 11/28/2015 03:56 PM, Loic Dachary wrote:
> Hi Ceph,
> 
> An optional teuthology field could be added to a commit message like so:
> 
> teuthology: --suite rbd
> 
> to state that this commit should be tested with the rbd suite. It could be parsed by bots and humans.
> 
> It would make it easy and cost effective to run partial teuthology suites automatically on pull requests.
> 
> What do you think ?

Can't we use git-notes for that instead?

I think this pollutes the history a bit. Especially considering this
sort of metadata isn't necessarily specific to a given diff.

Also should be considered that this is a field that may make sense today
but may not make much sense in 10, 15 years. And while we have quite a
few special-purpose fields (e.g., Fixes, Backport), those are currently
pretty explanatory and I believe will be still easily understandable in
a decade's time.

In any case, if there's absolutely no other way to do this and the other
folk thinks it's important to have this, I will certainly not be the
party pooper ;)

  -Joao

  reply	other threads:[~2015-11-29 11:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-28 15:56 RFC: teuthology field in commit messages Loic Dachary
2015-11-29 11:51 ` Joao Eduardo Luis [this message]
2015-11-29 14:58   ` Loic Dachary
2015-11-29 20:08 ` John Spray
2015-11-29 20:25   ` Loic Dachary
2015-11-29 20:47     ` John Spray
2015-11-29 21:25       ` Loic Dachary
2015-11-29 22:55         ` John Spray
2015-11-29 23:15           ` Loic Dachary
2015-11-30 15:15             ` Gregory Farnum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565AE6BF.4040701@suse.de \
    --to=joao@suse.de \
    --cc=ceph-devel@vger.kernel.org \
    --cc=loic@dachary.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.