All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Hellstrom <thellstrom@vmware.com>
To: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Advice on fixing unwanted master inheritance:
Date: Sun, 29 Nov 2015 18:44:03 +0100	[thread overview]
Message-ID: <565B3963.50309@vmware.com> (raw)

Hi, all!

There's an odd master inheritance going on in drm. Consider the
following scenario.

1) Xorg opens DRM. Becomes master.
2) Plymouthd opens a file descriptor to drm.
3) Xorg exits.
4) Plymouthd calls drmSetMaster(). At this point it actually inherits
Xorg's master structure and all authenticated clients.
5) vmwgfx dislikes this and throws a BUG().

I can of course fix vmwgfx up to not throw a bug in this case, but I
figure this behavior is not really what we want, so I'd like to fix the
root cause as well, As I see it, we have two options.

A) If the client is authenticated with the master we allow the above
behaviour as a way to change master role in a master realm. If the
client is not authenticated, like Plymouthd in this case, we create a
new master structure for Plymouthd.

B) This behaviour is not allowed at all. We always create a new master
structure when this happens.

Opinions?

Thanks,
Thomas
 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2015-11-29 17:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-29 17:44 Thomas Hellstrom [this message]
2015-11-29 19:48 ` Advice on fixing unwanted master inheritance: Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565B3963.50309@vmware.com \
    --to=thellstrom@vmware.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.