All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tilman Schmidt <tilman@imap.cc>
To: Peter Hurley <peter@hurleysoftware.com>,
	Sasha Levin <sasha.levin@oracle.com>
Cc: pebolle@tiscali.nl, isdn@linux-pingi.de, davem@davemloft.net,
	gigaset307x-common@lists.sourceforge.net,
	LKML <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	syzkaller <syzkaller@googlegroups.com>
Subject: Re: gigaset: freeing an active object
Date: Sun, 29 Nov 2015 19:38:05 +0100	[thread overview]
Message-ID: <565B460D.9080002@imap.cc> (raw)
In-Reply-To: <565B4256.6080101@hurleysoftware.com>

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

Am 29.11.2015 um 19:22 schrieb Peter Hurley:
> On 11/29/2015 10:30 AM, Tilman Schmidt wrote:
>>
>> Judging from the backtrace below this must be the call
>>
>>         kfree(cs->hw.ser);
>>
>> in drivers/isdn/gigaset/ser-gigaset.c line 375.
>> cs->hw.ser is of type struct ser_cardstate *.
>> struct ser_cardstate consists of a struct platform_device, a struct
>> completion, an atomic_t and a pointer. No timer_list.
[...]
> 
> The platform_device embedded in struct ser_cardstate hasn't been released when
> you kfree() the memory it's in.

How so? The kfree() call quoted above is immediately preceded by:

        platform_device_unregister(&cs->hw.ser->dev);

Thanks,
Tilman

-- 
Tilman Schmidt                              E-Mail: tilman@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2015-11-29 18:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-27 15:19 gigaset: freeing an active object Sasha Levin
2015-11-27 17:57 ` Paul Bolle
2015-11-27 18:15   ` Sasha Levin
2015-11-28  0:28     ` Paul Bolle
2015-11-28  1:20       ` Peter Hurley
2015-11-28  1:27         ` Sasha Levin
2015-11-29 14:36           ` Dmitry Vyukov
2015-11-29 15:30 ` Tilman Schmidt
2015-11-29 18:22   ` Peter Hurley
2015-11-29 18:38     ` Tilman Schmidt [this message]
2015-11-29 18:47     ` Tilman Schmidt
2015-11-29 20:26       ` Paul Bolle
2015-11-29 23:23         ` Paul Bolle
2015-11-29 23:23           ` Paul Bolle
2015-11-30 18:01           ` Paul Bolle
2015-11-30 18:30             ` Tilman Schmidt
2015-11-30 21:07               ` Paul Bolle
2015-12-01  9:30                 ` Tilman Schmidt
2015-12-01 10:05                   ` Paul Bolle
2015-12-02 23:48             ` Peter Hurley
2015-12-06 13:31               ` Paul Bolle
2015-12-06 15:29                 ` Tilman Schmidt
2015-12-06 20:12                   ` Paul Bolle
2015-12-07  9:27                     ` Tilman Schmidt
2015-12-07 12:25                       ` Paul Bolle
2015-12-07 18:40                         ` Tilman Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565B460D.9080002@imap.cc \
    --to=tilman@imap.cc \
    --cc=davem@davemloft.net \
    --cc=gigaset307x-common@lists.sourceforge.net \
    --cc=isdn@linux-pingi.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=peter@hurleysoftware.com \
    --cc=sasha.levin@oracle.com \
    --cc=syzkaller@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.