All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sheng Yong <shengyong1@huawei.com>
To: chao2.yu@samsung.com, jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH V3 2/2] mkfs.f2fs: skip extension name that is too long
Date: Mon, 30 Nov 2015 10:58:08 +0800	[thread overview]
Message-ID: <565BBB40.3010206@huawei.com> (raw)
In-Reply-To: <1448880067-9629-2-git-send-email-shengyong1@huawei.com>

Hi, Chao Yu, Jaegeuk

I'm not sure if it is ok to send this patch out by me. If I did it the
wrong way, please ignore this patch.

thanks,
Sheng

On 11/30/2015 6:41 PM, Sheng Yong wrote:
> From: Chao Yu <chao2.yu@samsung.com>
> 
> The length of extension name has a limit of 8 bytes. If an extension
> exceeds the limitation, it will not be added to the extension_list.
> 
> Signed-off-by: Chao Yu <chao2.yu@samsung.com>
> Signed-off-by: Sheng Yong <shengyong1@huawei.com>
> ---
>  mkfs/f2fs_format.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
> index a29d7ef..212df60 100644
> --- a/mkfs/f2fs_format.c
> +++ b/mkfs/f2fs_format.c
> @@ -157,8 +157,13 @@ static void configure_extension_list(void)
>  	ue = strtok(ext_str, ", ");
>  	while (ue != NULL) {
>  		name_len = strlen(ue);
> +		if (name_len >= 8) {
> +			MSG(0, "\tWarn: Extension name (%s) is too long\n", ue);
> +			goto next;
> +		}
>  		if (!is_extension_exist(ue))
>  			memcpy(sb.extension_list[i++], ue, name_len);
> +next:
>  		ue = strtok(NULL, ", ");
>  		if (i >= F2FS_MAX_EXTENSION)
>  			break;
> 


------------------------------------------------------------------------------
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140

  reply	other threads:[~2015-11-30  2:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 10:41 [PATCH V3 1/2] mkfs.f2fs: avoid dumplicate extensions Sheng Yong
2015-11-30 10:41 ` [PATCH V3 2/2] mkfs.f2fs: skip extension name that is too long Sheng Yong
2015-11-30  2:58   ` Sheng Yong [this message]
2015-12-01 14:20     ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565BBB40.3010206@huawei.com \
    --to=shengyong1@huawei.com \
    --cc=chao2.yu@samsung.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.