All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@windriver.com>
To: <rongqing.li@windriver.com>, <yocto@yoctoproject.org>
Subject: Re: [PATCH][yocto-kernel-cache] netfilter: enable several netfilter options
Date: Mon, 30 Nov 2015 00:22:05 -0500	[thread overview]
Message-ID: <565BDCFD.5060103@windriver.com> (raw)
In-Reply-To: <1448515549-24417-1-git-send-email-rongqing.li@windriver.com>

On 2015-11-26 12:25 AM, rongqing.li@windriver.com wrote:
> From: Roy Li <rongqing.li@windriver.com>
>
> the below kernel options are enabled:
>      LOG target support
>      IPv6 connection tracking support,
>      "addrtype" address type match support
>      "recent" match support
>
> the default configuration of ufw(Uncomplicated Firewall) asked them.

Like the other patch you submitted, this should go to the linux-yocto
list, but I'll reply here, since this one needs a bit more tweaking.

>
> Signed-off-by: Roy Li <rongqing.li@windriver.com>
> ---
>   features/netfilter/netfilter.cfg | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/features/netfilter/netfilter.cfg b/features/netfilter/netfilter.cfg
> index 8ecef4a..7bb8490 100644
> --- a/features/netfilter/netfilter.cfg
> +++ b/features/netfilter/netfilter.cfg
> @@ -62,12 +62,16 @@ CONFIG_NETFILTER_XT_MATCH_STATISTIC=m
>   CONFIG_NETFILTER_XT_MATCH_STRING=m
>   CONFIG_NETFILTER_XT_MATCH_TCPMSS=m
>   CONFIG_NETFILTER_XT_MATCH_U32=m
> +CONFIG_NETFILTER_XT_MATCH_ADDRTYPE=m
> +CONFIG_NETFILTER_XT_MATCH_RECENT=m
> +CONFIG_NETFILTER_XT_TARGET_LOG=m

Adding these are fine, but if ufw needs these extra options, we should
also have a ufw.scc/.cfg fragment that can be triggered when ufw is
being built.

So either create that fragment and inside it, document the NF options
it needs, and have ufw include netfilter.scc to get the options you
are adding above.

or .. at the very least, put comments in the .cfg file above the
options indicating that they are required for ufw.

Bruce

>
>   #
>   # IP: Netfilter Configuration
>   #
>   CONFIG_NF_DEFRAG_IPV4=m
>   CONFIG_NF_CONNTRACK_IPV4=m
> +CONFIG_NF_CONNTRACK_IPV6=m
>   CONFIG_NF_CONNTRACK_PROC_COMPAT=y
>   CONFIG_IP_NF_IPTABLES=m
>   CONFIG_IP_NF_MATCH_AH=m
>



  reply	other threads:[~2015-11-30  5:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26  5:25 [PATCH][yocto-kernel-cache] netfilter: enable several netfilter options rongqing.li
2015-11-30  5:22 ` Bruce Ashfield [this message]
2015-12-01  1:08   ` Rongqing Li
2015-12-01  5:24     ` Bruce Ashfield
2015-12-07 22:17       ` Bruce Ashfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565BDCFD.5060103@windriver.com \
    --to=bruce.ashfield@windriver.com \
    --cc=rongqing.li@windriver.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.