From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [PATCH v2 1/2] ACPI / scan: Fix acpi_bus_id_list bookkeeping
Date: Mon, 30 Nov 2015 14:27:49 +0800
Message-ID: <565BEC65.90409@huawei.com>
References: <cover.1448480385.git.lukas@wunner.de> <994278b96189033970d0a2add95645110c716fbb.1448480385.git.lukas@wunner.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <linux-acpi-owner@vger.kernel.org>
Received: from szxga01-in.huawei.com ([58.251.152.64]:34498 "EHLO
	szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751907AbbK3G3N (ORCPT
	<rfc822;linux-acpi@vger.kernel.org>); Mon, 30 Nov 2015 01:29:13 -0500
In-Reply-To: <994278b96189033970d0a2add95645110c716fbb.1448480385.git.lukas@wunner.de>
Sender: linux-acpi-owner@vger.kernel.org
List-Id: linux-acpi@vger.kernel.org
To: Lukas Wunner <lukas@wunner.de>, linux-acpi@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>
Cc: devel@acpica.org, Robert Moore <robert.moore@intel.com>, Mark Brown <broonie@kernel.org>, Hui Wang <hui.wang@canonical.com>, Darren Hart <dvhart@infradead.org>

Hi Lucas,

Sorry for the late reply, please see comments below.

On 2015/11/26 4:19, Lukas Wunner wrote:
> acpi_device_add() allocates and adds an element to acpi_bus_id_list
> (or increments the instance count if the device's HID is already
> present in the list), but the element is never deleted from the list
> nor freed. Fix it.

Hmm, I didn't get it here. Seems the device's ID already freed in device core:

 In acpi_add_single_object(), acpi_device_release() registered as a callback,
...
  result = acpi_device_add(device, acpi_device_release);
...

And in acpi_device_release(), it will call acpi_free_pnp_ids() to free the
IDs, did I miss some something?

Thanks
Hanjun