From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [radeon r100] when ring test fails, provide users with option to test Date: Mon, 30 Nov 2015 09:39:54 +0100 Message-ID: <565C0B5A.2040103@amd.com> References: <20151128205840.GA26757@amd> <565B56A5.4080702@amd.com> <20151129222235.GA25692@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0060.outbound.protection.outlook.com [157.56.111.60]) by gabe.freedesktop.org (Postfix) with ESMTPS id 52FA56E316 for ; Mon, 30 Nov 2015 00:40:20 -0800 (PST) In-Reply-To: <20151129222235.GA25692@amd> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Pavel Machek Cc: alexander.deucher@amd.com, Trivial patch monkey , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gMjkuMTEuMjAxNSAyMzoyMiwgUGF2ZWwgTWFjaGVrIHdyb3RlOgo+IE9uIFN1biAyMDE1LTEx LTI5IDIwOjQ4OjUzLCBDaHJpc3RpYW4gS8O2bmlnIHdyb3RlOgo+PiBPbiAyOC4xMS4yMDE1IDIx OjU4LCBQYXZlbCBNYWNoZWsgd3JvdGU6Cj4+PiBSaW5nIHRlc3QgZmFpbHVyZSBpcyBvZnRlbiBj YXVzZWQgYnkgdG9vIGhpZ2ggYWdwbW9kZS4gVGVsbCB0aGUgdXNlcgo+Pj4gd2hhdCB0byB0cnku Cj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogUGF2ZWwgTWFjaGVrIDxwYXZlbEB1Y3cuY3o+Cj4+IE5B SywgdGhlIHJpbmcgdGVzdCBjYW4gZmFpbCBmb3IgYW55IG51bWJlciBvZiByZWFzb25zIGFuZCB0 aGUgYWdwbW9kZSBpcwo+PiBhY3R1YWxseSByYXRoZXIgdW5saWtlbHkgdG8gYmUgdGhlIGNhdXNl Lgo+IFdlbGwsIHdoZW4gSSBhc2tlZCBvbiB0aGUgbGlzdCAid2h5IHRoaXMgaXMgaGFwcGVuZWQi IEkgZ290ICJ1bW0sCj4gbm9vbmUga25vd3MiIHJlc3BvbnNlIHRoYXQgd2FzIG5vdCBleGFjdGx5 IGhlbHBmdWwuIEFuZCB0aGVuIHNvbWVvbmUKPiB0b2xkIG1lIGFib3V0IGFncG1vZGUuCj4KPiBJ ZiB5b3Uga25vdyBhYm91dCB0aGUgcmVhc29ucyBpdCBjYW4gZmFpbCwgY291bGQgeW91IGxpc3Qg dGhlbSBuZWFyCj4gdGhlIERSTV9FUlJPUiwgYXQgbGVhc3QgYXMgYSBjb21tZW50PwoKV2VsbCBh cyBJIHNhaWQsIHRoYXQgY291bGQgYmUgYW55IG51bWJlciBvZiByZWFzb25zLiBTb21lIG9mIHRo ZW0gZXZlbiAKY29tcGxldGVseSB1bnJlbGF0ZWQgdG8gdGhlIGRyaXZlciBpdHNlbGYuCgpFLmcu IEJJT1Mgc2V0dGluZywgZmF1bHR5IGhhcmR3YXJlLCBwcm9ibGVtcyB3aXRoIHRoZSB3cml0ZWJh Y2sgZXRjLi4uIApUaGVyZSBpcyByZWFsbHkgbm90IGEgbGlzdCB5b3UgY291bGQgZ2l2ZSBoZXJl LgoKTG93ZXJpbmcgdGhlIGFncG1vZGUgdXN1YWxseSBoZWxwcyBtb3JlIHRvIHByZXZlbnQgcmFu ZG9tIGNvcnJ1cHRpb25zIAphbmQgcHJvYmxlbXMgdW5kZXIgbG9hZC4KClJlZ2FyZHMsCkNocmlz dGlhbi4KCj4KPiBUaGFua3MsCj4gCQkJCQkJCQkJUGF2ZWwKPgo+PiBSZWdhcmRzLAo+PiBDaHJp c3RpYW4uCj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yMTAwLmMg Yi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3IxMDAuYwo+Pj4gaW5kZXggMjM4YjEzZi4uMzJiMTkx NyAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcjEwMC5jCj4+PiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3IxMDAuYwo+Pj4gQEAgLTM2NjUsNyArMzY2NSw3IEBA IGludCByMTAwX3JpbmdfdGVzdChzdHJ1Y3QgcmFkZW9uX2RldmljZSAqcmRldiwgc3RydWN0IHJh ZGVvbl9yaW5nICpyaW5nKQo+Pj4gICAJaWYgKGkgPCByZGV2LT51c2VjX3RpbWVvdXQpIHsKPj4+ ICAgCQlEUk1fSU5GTygicmluZyB0ZXN0IHN1Y2NlZWRlZCBpbiAlZCB1c2Vjc1xuIiwgaSk7Cj4+ PiAgIAl9IGVsc2Ugewo+Pj4gLQkJRFJNX0VSUk9SKCJyYWRlb246IHJpbmcgdGVzdCBmYWlsZWQg KHNjcmF0Y2goMHglMDRYKT0weCUwOFgpXG4iLAo+Pj4gKwkJRFJNX0VSUk9SKCJyYWRlb246IHJp bmcgdGVzdCBmYWlsZWQgKHNjcmF0Y2goMHglMDRYKT0weCUwOFgpLCB0cnkgcmFkZW9uLmFncG1v ZGU9MT9cbiIsCj4+PiAgIAkJCSAgc2NyYXRjaCwgdG1wKTsKPj4+ICAgCQlyID0gLUVJTlZBTDsK Pj4+ICAgCX0KPj4+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753607AbbK3IkW (ORCPT ); Mon, 30 Nov 2015 03:40:22 -0500 Received: from mail-bn1bon0074.outbound.protection.outlook.com ([157.56.111.74]:51202 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753208AbbK3IkU (ORCPT ); Mon, 30 Nov 2015 03:40:20 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [radeon r100] when ring test fails, provide users with option to test To: Pavel Machek References: <20151128205840.GA26757@amd> <565B56A5.4080702@amd.com> <20151129222235.GA25692@amd> CC: Trivial patch monkey , , , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <565C0B5A.2040103@amd.com> Date: Mon, 30 Nov 2015 09:39:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151129222235.GA25692@amd> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:f678:3641:f475:450:ab52:37db] X-ClientProxiedBy: DB4PR07CA024.eurprd07.prod.outlook.com (10.242.229.34) To BY2PR12MB0129.namprd12.prod.outlook.com (25.162.82.155) X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0129;2:LjxMxfKVLSlK6AaYU/ETwjwhwZq03MsGeKgLSQ7EIbah7leL/lXTx1tLzeSt1ZFU+dBsF5t/1YxeMcq9rEhDYVhhy0gzBikLxXEwrafMTOEcyZ6+GgwNXUOrMtpTra0Di9jfAqC/Om1P3BfhDj7OYA==;3:iWQ4dZFEikJCiiCarzugWJ0PVj1w77HF2VLM3NEw5R1YZi4bGTqV1/ps6tf6U5p6/UsUYi16pgJb5dwWj9SmmXIdd53w7OYBMDOQDeQ4ityt9GlFxtwAO4B6+0lwuRKH;25:TT0uQlirfNpmshxr8u1yt1YmpNJOHpAMnN1X6PcPu8HJaWX1MIOL8zx9IFJHOhDaWVD5xzLA2ssMDPkUvdawUYJydnKoH/+yTlES6jzMEqENXZv0jni3f0Wlc8yJu7MBmmEaVrOf4Bs0egGlvVCjcZjunRZSq2JE0fTQfm5c3l9wbr60Au479E0R8kuO6jLb/TvIYsJGhFbbQfWxI9RJPQz9kF1/TmQ6hkeU8OCM3kxxT/7c+WDl7TvWkcFg2Lio X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR12MB0129; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0129;20:1n/zxWRcCDNwGwjBufdPoLnkhqjIGrc9fphFH+M9XKX55cJg/YNfBFgQCX1Wr0LcPhKx11/pQV5BcoC+K2oeBnTzituR9ZRotPc+gcahAJsokp+8HcGPPwkNeyM5EVJnoLfupUeR1Ki3M9e78zOEOu6NrAs2+/ILZxJBJMCAxHy9ypWSdBb0HuQvnZL2+Wvf/6DWwXEkS0P7phpwGxSypzjQ1YKpesrNJmGzBvNneTpOh/+2Bg691ujQ6KQCSb5MfzqU7bCEIY8GPh4kDehC4mJAtBPZbPALB7ysyhCn4cGjHEd0JWn56mUuVah2SY/J1I4/7Q6UGwpgfoRyzeIWFHgtd3edcrRqCnk3UkUc5wdMhvxVJv8HDsFoxi8BBrHMJTBuKnlIOFrYq2HxKyuXGkVWxnOJlGApdiNwMHLx2GaJMaycuYtDzftSalSz8F3EdXJh8E4vZ4Geoy+tgqECmUpUWgY4ZnLURduD6gNjMLN6u2XKzM2hXxD1jVRL137d;4:F/SnF+zYB07BuRzMCSI12MeYwEzU2Hq79l3KCqdUpTN/xWphiDCIXpAIEcJ8lRMaNPIOgV0/qGVxdBkYkl+4i21AHfoD7vI9Ou5HE0p50IpTBolsm9opB2eVbqAhAtHpkGxI3nCquEpIimcl/3iScRjmUglMtNhSLbxCuxqrkCmtklXRLxwvVcclSOfIEIEbUVReyfm++gq97xzLY+SuINpbggUL04ZEjgQuupY8S+BWKTABjoWNlTr3XzBF40HO36m/YxJg4iA8ti0TfPCPGRYUK2UuP0fzTp+hzA9qVG/jTDh3+cCvx5mz+Zf2Lmpq60txz9QbTyIfLQl5rRLDI8+mz6relMelxqWz08LzEXDiHImEfG2xp90AitjEm/FU X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(10201501046)(3002001);SRVR:BY2PR12MB0129;BCL:0;PCL:0;RULEID:;SRVR:BY2PR12MB0129; X-Forefront-PRVS: 0776C39A48 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(164054003)(377424004)(24454002)(189002)(199003)(42186005)(65806001)(50466002)(4001150100001)(92566002)(50986999)(80316001)(86362001)(19580405001)(81156007)(87976001)(77096005)(5001960100002)(19580395003)(97736004)(54356999)(87266999)(189998001)(64126003)(65816999)(65956001)(101416001)(110136002)(5008740100001)(1706002)(33656002)(59896002)(47776003)(83506001)(23746002)(4001350100001)(76176999)(2950100001)(5004730100002)(106356001)(105586002)(586003)(36756003)(122386002)(1096002)(40100003)(6116002)(3826002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR12MB0129;H:[IPv6:2a02:908:f678:3641:f475:450:ab52:37db];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY2PR12MB0129;23:Y11YyyJbDDeYs9YUn19BaM/s88TpM2xJ9GiUS?= =?Windows-1252?Q?jUfSumdiyGoWrCwG9JPOMOY7ewwRV76XHbrOI0jwD53caXWzWU0LGzn5?= =?Windows-1252?Q?aODm91r3pD+cXLcBk1KdSzaGOIDsUpZ3FwbIirZhrB8oS44kv4Di1ya0?= =?Windows-1252?Q?vMp3rFp9GpIhMvy2PSedvyJ8ChXvKI4Bd/TaQcGRUlvy/L/oyAzd2FY2?= =?Windows-1252?Q?iREREvEBhoJ41OS6NF4DlDweP0ZrzJUEwdw1eVy7MQswfMM1TzXA30xR?= =?Windows-1252?Q?MhjZWKgSgZ4vZyk4eEo8VeaVlrvPV2FJBPxkWfy/ZSYzVud5Zu5AwBM3?= =?Windows-1252?Q?/gwEv8KemtQpL1/Tgpu4e6IPJLhN+8jiQPfgyOFxVczzXFipRbDeJVGi?= =?Windows-1252?Q?MO1nfAbEVA/86VeWruUhfQJJ+c3WFIniDKfR2DsTNhy3HlA8+C2x39cU?= =?Windows-1252?Q?VXTXMWzcdZv8kLx5h7i77RNs+3F7IYv2LgJmWx3B0LacjBNc1mXrZzd6?= =?Windows-1252?Q?rhryucMJdOcgmm31zzQr0W5DA8xEleb7+xFT0JXtkZgGhk+LlN77XQKO?= =?Windows-1252?Q?aeOJrn0H1NUN6IR6QmVMK8P25ssjXklXp1H9NzCxltwnD4SbQ9Ucu+sF?= =?Windows-1252?Q?n9pPC1kHaIsphRFWP8g/LA9e3tf9NUPbWbtwfDBDz+KbklZ6B3fR8gnY?= =?Windows-1252?Q?j2nkSt2DyLh7w85EpeM+tQhqYKRQ4mTi6IZdjuk7UQYuuUBM3L4ubqWP?= =?Windows-1252?Q?rnNa11OHai7QN1bPZgIuyehPCUNA7VogSGX8PhpFuT4W7iNcu6fDmpdM?= =?Windows-1252?Q?eAh8rzd0a81Utci7OtmBJ+HuWKMEIlf2jnXB7GrjqfxXr24KTHIJnNcg?= =?Windows-1252?Q?MGkDb/cLCyp66MN5LTXV9hbyfjFTrVyRGT6H/zD8rhRDGQpYsD9FSZEn?= =?Windows-1252?Q?D2AQOj5urpwRJaSZz19lwzXBbsw2dVIE4Wc00c9gnI859hkgiOYCcnc7?= =?Windows-1252?Q?UEAgFgRNJXMCQ7vFSXCz6ndqwDNhXc8f99EGKvWz97ZbaHn3ofxRsmDS?= =?Windows-1252?Q?Dd0oVk6opHqhE/OhNubbrwNvrG9iMLbHqP5VFYmlvwIi4G6RsQ0HHd1a?= =?Windows-1252?Q?tngWMdYg/aRCs4/X0W5PaQYygc82CuS8AMAU0o2NCsymi+vjmBzfl+qw?= =?Windows-1252?Q?lo6XY6P9lyFbtLIgUNrV3jvxoRqepboRWktpfO2RfMxAkwNSzHYFFw1G?= =?Windows-1252?Q?yDZCwJGVPDRqwJy3z0r454tp9EXTYzqdsL55LAw1FI/hqsuRYUmubRPj?= =?Windows-1252?Q?8cpjwMrxRnbuJBYv8r6DuxcOHnK2wVTXg5zYoWgLSVDBzybDQdJQ/DDH?= =?Windows-1252?Q?bnlMMTmu/JK?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0129;5:bspGjK6RLoE80VdKR23ceckifZToIcKmnxNnpwm/2KuFo7Vmnfak324nqg0edZiDdJ6Vsn5RcWklfa8IW2cpyUBp8vZrUWFYl029U5JZ0W3vJofRVIiFBqrDY46x22LqJ82+EWongYF4FmXaFqL0lw==;24:Y0Hhp9odnsV/IqtpxkSr5cUlm5cbmZutm3KEGr3FAW+kRoVjJQl7c/Uh4s1LxXK7rzxmDmIDnPPjatZfl+c5ouoFzPjAzBRHTZ4jMMq1+Uo=;20:tJ9DzHkCoSl/FgWjOCLJwmNnaFrcSdElK4fKwM2vOY0CjST1GUaRSurVIUTMzW4UDzFy7hpfWh7OcLitwWjpW98XxXDFdjGXiho/Ykhu5ZiVmdqIkiAh9xCzqAku7rdvzENHjGOtvBSR82lWW15OKaFXb7wd9Kk3C7p3OUh8C2Vk0qj5q0Ger/AGDv2HEljkYgsHU3c1LNueHiLUl959pK3ylrbN5i9GX9IhoJ2fcYRhryDRSjdI7d/s/yXpIAPe X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2015 08:40:14.5232 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0129 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.11.2015 23:22, Pavel Machek wrote: > On Sun 2015-11-29 20:48:53, Christian König wrote: >> On 28.11.2015 21:58, Pavel Machek wrote: >>> Ring test failure is often caused by too high agpmode. Tell the user >>> what to try. >>> >>> Signed-off-by: Pavel Machek >> NAK, the ring test can fail for any number of reasons and the agpmode is >> actually rather unlikely to be the cause. > Well, when I asked on the list "why this is happened" I got "umm, > noone knows" response that was not exactly helpful. And then someone > told me about agpmode. > > If you know about the reasons it can fail, could you list them near > the DRM_ERROR, at least as a comment? Well as I said, that could be any number of reasons. Some of them even completely unrelated to the driver itself. E.g. BIOS setting, faulty hardware, problems with the writeback etc... There is really not a list you could give here. Lowering the agpmode usually helps more to prevent random corruptions and problems under load. Regards, Christian. > > Thanks, > Pavel > >> Regards, >> Christian. >> >>> diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c >>> index 238b13f..32b1917 100644 >>> --- a/drivers/gpu/drm/radeon/r100.c >>> +++ b/drivers/gpu/drm/radeon/r100.c >>> @@ -3665,7 +3665,7 @@ int r100_ring_test(struct radeon_device *rdev, struct radeon_ring *ring) >>> if (i < rdev->usec_timeout) { >>> DRM_INFO("ring test succeeded in %d usecs\n", i); >>> } else { >>> - DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X)\n", >>> + DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X), try radeon.agpmode=1?\n", >>> scratch, tmp); >>> r = -EINVAL; >>> } >>>