From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [for-2.6 PATCH 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes Date: Mon, 30 Nov 2015 12:21:23 +0100 Message-ID: <565C3133.2060707@redhat.com> References: <1448740611-3096-1-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: kvm@vger.kernel.org, Huaitong Han To: Eduardo Habkost , qemu-devel@nongnu.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45152 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750892AbbK3LV1 (ORCPT ); Mon, 30 Nov 2015 06:21:27 -0500 In-Reply-To: <1448740611-3096-1-git-send-email-ehabkost@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 28/11/2015 20:56, Eduardo Habkost wrote: > I still need to figure out a way to write unit tests for the new > code. Maybe I will just copy and paste the new and old functions, > and test them locally (checking if they give the same results > when translating blobs of random bytes). Aren't the QEMU_BUILD_BUG_ON enough? No need to delete them in patch 3, though perhaps you can remove the #defines. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3MWS-0001b0-LR for qemu-devel@nongnu.org; Mon, 30 Nov 2015 06:21:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3MWN-0000pk-Ly for qemu-devel@nongnu.org; Mon, 30 Nov 2015 06:21:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3MWN-0000pe-GQ for qemu-devel@nongnu.org; Mon, 30 Nov 2015 06:21:27 -0500 References: <1448740611-3096-1-git-send-email-ehabkost@redhat.com> From: Paolo Bonzini Message-ID: <565C3133.2060707@redhat.com> Date: Mon, 30 Nov 2015 12:21:23 +0100 MIME-Version: 1.0 In-Reply-To: <1448740611-3096-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [for-2.6 PATCH 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Huaitong Han , kvm@vger.kernel.org On 28/11/2015 20:56, Eduardo Habkost wrote: > I still need to figure out a way to write unit tests for the new > code. Maybe I will just copy and paste the new and old functions, > and test them locally (checking if they give the same results > when translating blobs of random bytes). Aren't the QEMU_BUILD_BUG_ON enough? No need to delete them in patch 3, though perhaps you can remove the #defines. Paolo