Re: [Qemu-devel] [PATCH] vmxnet3: silence warning under qtest

[Paolo Bonzini <pbonzini@redhat.com>]

On 30/11/2015 12:19, Michael S. Tsirkin wrote:
> This is not a user error, don't warn.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  hw/net/vmxnet3.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> index 5e3a233..0e9e6d9 100644
> --- a/hw/net/vmxnet3.c
> +++ b/hw/net/vmxnet3.c
> @@ -25,6 +25,7 @@
>  #include "qemu/bswap.h"
>  #include "hw/pci/msix.h"
>  #include "hw/pci/msi.h"
> +#include "sysemu/qtest.h"
>  
>  #include "vmxnet3.h"
>  #include "vmxnet_debug.h"
> @@ -2015,7 +2016,9 @@ static bool vmxnet3_peer_has_vnet_hdr(VMXNET3State *s)
>          return true;
>      }
>  
> -    VMW_WRPRN("Peer has no virtio extension. Task offloads will be emulated.");
> +    if (!qtest_enabled()) {
> +        VMW_WRPRN("Peer has no virtio extension. Task offloads will be emulated.");
> +    }
>      return false;
>  }

Let's just delete it, there's no similar warning for virtio.

Paolo