From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 02/11] xen/arm: vgic-v3: Don't try to emulate IROUTER which doesn't exist in the spec Date: Mon, 30 Nov 2015 12:13:29 +0000 Message-ID: <565C3D69.2060503@citrix.com> References: <1447867686-19371-1-git-send-email-julien.grall@citrix.com> <1447867686-19371-3-git-send-email-julien.grall@citrix.com> <1448385466.26412.73.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a3NM7-0007N7-Ut for xen-devel@lists.xenproject.org; Mon, 30 Nov 2015 12:14:56 +0000 In-Reply-To: <1448385466.26412.73.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xenproject.org Cc: stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 24/11/15 17:17, Ian Campbell wrote: > On Wed, 2015-11-18 at 17:27 +0000, Julien Grall wrote: > > Subject: ... which do not exist in the ... > >> The range of valid IROUTER are n = 32 - 1019 (see 8.9.13 in IHI 0069A) >> which correspond to the offset 0x6100-0x7FD8. >> >> Other offset are invalid and therefore should not be emulated. > > "offsets" > >> >> Also remove the now unused label read_as_zero_64 and write_ignore_64. >> >> Note that GICD_IROUTER is kept to accomadate the GICv3 drivers which has > > "accommodate" > >> been in part taken from Linux. >> >> Signed-off-by: Julien Grall > > Accesses to 0x6000-0x60FF are going to be noisy now, I suppose that is OK. Well, those registers are reserved so the guests are not supposed to access them. > Acked-by: Ian Campbell Thank you! Regards, -- Julien Grall