From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH v7] leds: ipaq-micro: Implement brightness_set_blocking op
Date: Mon, 30 Nov 2015 13:27:21 +0100 [thread overview]
Message-ID: <565C40A9.9010507@samsung.com> (raw)
In-Reply-To: <CACRpkdZ2KjgfcTwy30KYhFx8gzRO0Q79Tb7YNuFeQ6qPWxT88g@mail.gmail.com>
On 11/30/2015 09:52 AM, Linus Walleij wrote:
> On Fri, Nov 20, 2015 at 4:57 PM, Jacek Anaszewski
> <j.anaszewski@samsung.com> wrote:
>
>> Since brightness setting can sleep for this driver, implement
>> brightness_set_blocking op, instead of brightness_set.
>> It makes this driver compatible with LED triggers.
>>
>> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> ---
>> Changes from v6:
>> - adjust micro_leds_brightness_set() return type to match
>> brightness_set_blocking op return type
>
> Even better.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Applied, thanks.
--
Best Regards,
Jacek Anaszewski
prev parent reply other threads:[~2015-11-30 12:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 15:57 [PATCH v7] leds: ipaq-micro: Implement brightness_set_blocking op Jacek Anaszewski
2015-11-30 8:52 ` Linus Walleij
2015-11-30 12:27 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565C40A9.9010507@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.