From mboxrd@z Thu Jan  1 00:00:00 1970
From: julien.grall@citrix.com (Julien Grall)
Date: Mon, 30 Nov 2015 15:30:54 +0000
Subject: [PATCH v3 58/62] xen/acpi: Fix event-channel interrupt when
 booting with ACPI
In-Reply-To: <alpine.DEB.2.02.1511271510350.8984@kaball.uk.xensource.com>
References: <1447753261-7552-1-git-send-email-shannon.zhao@linaro.org>
 <1447753261-7552-59-git-send-email-shannon.zhao@linaro.org>
 <alpine.DEB.2.02.1511271510350.8984@kaball.uk.xensource.com>
Message-ID: <565C6BAE.5000600@citrix.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On 27/11/15 15:12, Stefano Stabellini wrote:
>> +    }
>> +    else
>> +    {
>> +        int type = 3;
>> +        int flag = 2; /* Active-low level-sensitive  */
>> +        d->arch.hvm_domain.params[HVM_PARAM_CALLBACK_IRQ] = (u64)type << 56
>> +                                                            | flag << 8
>> +                                                            | d->arch.evtchn_irq;
>> +    }
>>  }
> 
> Actually there is no point in setting HVM_PARAM_CALLBACK_IRQ only on
> ACPI: I would just set it on all cases.

+1

Regards,

-- 
Julien Grall

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v3 58/62] xen/acpi: Fix event-channel
 interrupt when booting with ACPI
Date: Mon, 30 Nov 2015 15:30:54 +0000
Message-ID: <565C6BAE.5000600@citrix.com>
References: <1447753261-7552-1-git-send-email-shannon.zhao@linaro.org>
	<1447753261-7552-59-git-send-email-shannon.zhao@linaro.org>
	<alpine.DEB.2.02.1511271510350.8984@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1511271510350.8984@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, shannon.zhao@linaro.org
Cc: mark.rutland@arm.com, hangaohuai@huawei.com, david.vrabel@citrix.com, keir@xen.org, ian.campbell@citrix.com, ard.biesheuvel@linaro.org, andrew.cooper3@citrix.com, peter.huangpeng@huawei.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, christoffer.dall@linaro.org, jbeulich@suse.com, zhaoshenglong@huawei.com, linux-arm-kernel@lists.infradead.org, roger.pau@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 27/11/15 15:12, Stefano Stabellini wrote:
>> +    }
>> +    else
>> +    {
>> +        int type = 3;
>> +        int flag = 2; /* Active-low level-sensitive  */
>> +        d->arch.hvm_domain.params[HVM_PARAM_CALLBACK_IRQ] = (u64)type << 56
>> +                                                            | flag << 8
>> +                                                            | d->arch.evtchn_irq;
>> +    }
>>  }
> 
> Actually there is no point in setting HVM_PARAM_CALLBACK_IRQ only on
> ACPI: I would just set it on all cases.

+1

Regards,

-- 
Julien Grall