From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/PV: hide features dependent on XSAVE
 when booted with "no-xsave"
Date: Mon, 30 Nov 2015 15:38:21 +0000
Message-ID: <565C6D6D.4000406@citrix.com>
References: <5658471802000078000B9A27@prv-mh.provo.novell.com>
	<56587149.6010909@citrix.com>
	<565C2C8502000078000BA18C@prv-mh.provo.novell.com>
	<565C28FE.80205@citrix.com>
	<565C3C2E02000078000BA250@prv-mh.provo.novell.com>
	<565C2EAF.7000003@citrix.com>
	<565C415802000078000BA299@prv-mh.provo.novell.com>
	<565C50DD.9040109@citrix.com>
	<565C77C002000078000BA518@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=769e600f3=Andrew.Cooper3@citrix.com>)
	id 1a3QX4-0003eJ-4F
	for xen-devel@lists.xenproject.org; Mon, 30 Nov 2015 15:38:26 +0000
In-Reply-To: <565C77C002000078000BA518@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 30/11/15 15:22, Jan Beulich wrote:
>>>> On 30.11.15 at 14:36, <andrew.cooper3@citrix.com> wrote:
>> On 30/11/15 11:30, Jan Beulich wrote:
>>> It's not well defined whether YMM register presence
>>> correlates to AVX, or is simply flagged by the respective XSTATE
>>> CPUID bit (or a mixture of both).
>> It is indeed not well defined, which is what makes this area of
>> functionality so hard to level safely.
>>
>>> The minimal (and imo more natural) dependency is just the XSTATE bit.
>> But it is wrong.
>>
>> Any VEX encoded SIMD operation unconditionally works on YMM state.  In
>> the case that XMM registers are encoded with a VEX prefix, the upper 128
>> bits of the YMM register are zeroed (SDM Vol 2, 2.3.10).  This is
>> contrary to legacy SSE instructions which preserve the upper 128 bits.
>>
>> Therefore, FMA, FMA4 and XOP do have a strict dependency on AVX.
> No, if you really want to express it that way, you'll need feature
> flags derived from the XSTATE bits.

What? That is absurd.

They depend on AVX.  I am not introducing a synthetic feature when the
real feature bits are correct.

~Andrew