From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v3] x86/VPMU: implement ipc and arch filter flags Date: Mon, 30 Nov 2015 14:56:03 -0500 Message-ID: <565CA9D3.9030808@oracle.com> References: <1448499732-3891-1-git-send-email-bgregg@netflix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1448499732-3891-1-git-send-email-bgregg@netflix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Brendan Gregg , xen-devel@lists.xen.org Cc: dietmar.hahn@ts.fujitsu.com List-Id: xen-devel@lists.xenproject.org On 11/25/2015 08:02 PM, Brendan Gregg wrote: > This introduces a way to have a restricted VPMU, by specifying one of two > predefined groups of PMCs to make available. For secure environments, this > allows the VPMU to be used without needing to enable all PMCs. > > Signed-off-by: Brendan Gregg > --- > Changes in v3: > * addressing review comments from Boris: > * ensure final flag is validated > * code tidy > > Changes in v2: > * feature flags can now be combined (eg, "vpmu=ipc,bts") > * addressing review comments from Boris: > * restrict DS_AREA and PEBS_ENABLE access when filters are in use > * better variable types > * include MSR_IA32_CMT_EVTSEL_UE_MASK flag > --- > docs/misc/xen-command-line.markdown | 14 +++++++++- > xen/arch/x86/cpu/vpmu.c | 51 +++++++++++++++++++++++++++++-------- > xen/arch/x86/cpu/vpmu_intel.c | 49 +++++++++++++++++++++++++++++++++++ > xen/include/asm-x86/msr-index.h | 1 + > xen/include/public/pmu.h | 14 ++++++++-- Reviewed-by: Boris Ostrovsky