All of lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] unzip: new package
Date: Mon, 30 Nov 2015 23:09:48 +0100	[thread overview]
Message-ID: <565CC92C.5080800@openwide.fr> (raw)
In-Reply-To: <565AEB25.7070605@lucaceresoli.net>

Hi Luca,

Le 29/11/2015 13:10, Luca Ceresoli a ?crit :
> Dear Romain,
> 
> Romain Naour wrote:
> [...]
>>> diff --git a/package/unzip/Config.in b/package/unzip/Config.in
>>> new file mode 100644
>>> index 0000000..0d98d28
>>> --- /dev/null
>>> +++ b/package/unzip/Config.in
>>> @@ -0,0 +1,11 @@
>>> +config BR2_PACKAGE_UNZIP
>>> +    bool "unzip"
>>
>> Have you checked some toolchain dependencies ?
>> It seems that process.c use wchar_t so "depends on BR2_USE_WCHAR" is needed.
> 
> The CMakeLists.txt that I wrote does never define UNICODE_SUPPORT nor
> UNICODE_WCHAR. So it builds both with and without wchar support, but
> never uses it. I would like to have a basic package working,
> conditional support can be added later at any time.
> 

Thanks for the answer, I only grepped for wchar_t, fork etc (usual build issues)
and I missed the UNICODE_SUPPORT/UNICODE_WCHAR conditional... my bad.
So your initial patch looks good except for the Busybox dependency as you
noticed ;-)

Best regards,
Romain

  reply	other threads:[~2015-11-30 22:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-27 17:38 [Buildroot] [PATCH 1/2] infozip: rename to zip Luca Ceresoli
2015-11-27 17:38 ` [Buildroot] [PATCH 2/2] unzip: new package Luca Ceresoli
2015-11-27 21:39   ` Arnout Vandecappelle
2015-11-27 22:23     ` Luca Ceresoli
2015-11-27 22:37       ` Arnout Vandecappelle
2015-11-27 22:45   ` Romain Naour
2015-11-29 12:10     ` Luca Ceresoli
2015-11-30 22:09       ` Romain Naour [this message]
2015-11-27 21:38 ` [Buildroot] [PATCH 1/2] infozip: rename to zip Arnout Vandecappelle
2015-11-27 22:15   ` Romain Naour
2015-11-28 17:22 ` Thomas Petazzoni
2015-12-06  9:23 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565CC92C.5080800@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.