From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [RFC PATCH 8/9] drm: bridge/dw_hdmi: Covert to support atomic API Date: Tue, 01 Dec 2015 16:07:02 +0800 Message-ID: <565D5526.7030009@rock-chips.com> References: <1448940391-23333-1-git-send-email-mark.yao@rock-chips.com> <1448940953-23604-1-git-send-email-mark.yao@rock-chips.com> <20151201072128.GF17050@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20151201072128.GF17050@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , Philipp Zabel , Andy Yan , Fabio Estevam , Thierry Reding List-Id: linux-rockchip.vger.kernel.org T24gMjAxNeW5tDEy5pyIMDHml6UgMTU6MjEsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gT24gVHVl LCBEZWMgMDEsIDIwMTUgYXQgMTE6MzU6NTNBTSArMDgwMCwgTWFyayBZYW8gd3JvdGU6Cj4+IEZp bGwgYXRvbWljIG5lZWRlZCBmdW5jcyB3aXRoIGRlZmF1bHQgYXRvbWljIGhlbHBlciBsaWJyYXJ5 Lgo+Pgo+PiBSb2NrY2hpcCB1c2UgZHdfaGRtaSwgYW5kIGRybS9yb2NrY2hpcCB3aWxsIGNvdmVy dCB0byBhdG9taWMgYXBpLAo+PiB3ZSBuZWVkIGR3X2hkbWkgc3VwcG9ydCBhdG9taWMgZnVuY3Mu Cj4+Cj4+IFNpZ25lZC1vZmYtYnk6IE1hcmsgWWFvIDxtYXJrLnlhb0Byb2NrLWNoaXBzLmNvbT4K PiBBcmVuJ3QgdGhlcmUgZHJpdmVycyBhcm91bmQgd2hpY2ggdXNlIGR3X2hkbWkgYW5kIHdoaWNo IGFyZSBzdGlsbCBub3QgeWV0Cj4gYXRvbWljPyBUaGlzIHdvdWxkIGJyZWFrIHRoZW0uIEkgdGhp bmsgd2UgbmVlZWQgdHdvIGNvbm5lY3Rvcl9mdW5jIHRhYmxlcwo+IGFuZCBkd19oZG1pIG5lZWRz IHRvIGNoZWNrIGZvciBEUklWRVJfQVRPTUlDIGF0IHJ1bnRpbWUgYW5kIHBpY2sgdGhlIHJpZ2h0 Cj4gdmVyc2lvbi4KClJpZ2h0LCBhbm90aGVyIGRybSBkcml2ZXIgdXNlIGR3X2hkbWkgaXMgaW14 LCBub3QgeWV0IGF0b21pYywgdGhpcyB3b3VsZCAKYnJlYWsgaXQuCmFzIHlvdSBzYWlkLCBJIHdv dWxkIHJlc2VuZCBhIHBhdGNoIHRvIGNoZWNrIERSSVZFUl9BVE9NSUMgYXQgcnVudGltZS4KClRo YW5rcwotTWFyawoKPgo+IFRoZSBsYXJnZXIgcHJvYmxlbSBoZXJlIGlzIHRoYXQgIndobyBzaG91 bGQgcmVnaXN0ZXIgdGhlIGRybV9jb25uZWN0b3IiIGlzCj4gYSBiaXQgYW4gdW5zb2x2ZWQgcHJv YmxlbSwgc2luY2UgYm90aCB0aGUgYnJpZGdlIGFuZCB0aGUgZHJpdmVyIHNob3VsZCBiZQo+IGFi bGUgdG8gY3VzdG9taXplL2FkanVzdCB0aGUgZHJtX2Nvbm5lY3RvciBhdCB0aGUgZW5kIG9mIGEg YnJpZGdlIGNoYWluLgo+IFRoaXMgaGVyZSBpcyBqdXN0IGFub3RoZXIgZXhhbXBsZSBvZiB0aGlz IHByb2JsZW0uCj4gLURhbmllbAo+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2Uv ZHdfaGRtaS5jIHwgICAgNiArKysrKy0KPj4gICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9uKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJp ZGdlL2R3X2hkbWkuYyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvZHdfaGRtaS5jCj4+IGluZGV4 IDU2ZGU5ZjEuLjU4NzA2NWEgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uv ZHdfaGRtaS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvZHdfaGRtaS5jCj4+IEBA IC0yMiw2ICsyMiw3IEBACj4+ICAgCj4+ICAgI2luY2x1ZGUgPGRybS9kcm1fb2YuaD4KPj4gICAj aW5jbHVkZSA8ZHJtL2RybVAuaD4KPj4gKyNpbmNsdWRlIDxkcm0vZHJtX2F0b21pY19oZWxwZXIu aD4KPj4gICAjaW5jbHVkZSA8ZHJtL2RybV9jcnRjX2hlbHBlci5oPgo+PiAgICNpbmNsdWRlIDxk cm0vZHJtX2VkaWQuaD4KPj4gICAjaW5jbHVkZSA8ZHJtL2RybV9lbmNvZGVyX3NsYXZlLmg+Cj4+ IEBAIC0xNTE1LDExICsxNTE2LDE0IEBAIHN0YXRpYyB2b2lkIGR3X2hkbWlfY29ubmVjdG9yX2Zv cmNlKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IpCj4+ICAgfQo+PiAgIAo+PiAgIHN0 YXRpYyBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9mdW5jcyBkd19oZG1pX2Nvbm5lY3Rvcl9mdW5jcyA9 IHsKPj4gLQkuZHBtcyA9IGRybV9oZWxwZXJfY29ubmVjdG9yX2RwbXMsCj4+ICsJLmRwbXMgPSBk cm1fYXRvbWljX2hlbHBlcl9jb25uZWN0b3JfZHBtcywKPj4gICAJLmZpbGxfbW9kZXMgPSBkcm1f aGVscGVyX3Byb2JlX3NpbmdsZV9jb25uZWN0b3JfbW9kZXMsCj4+ICAgCS5kZXRlY3QgPSBkd19o ZG1pX2Nvbm5lY3Rvcl9kZXRlY3QsCj4+ICAgCS5kZXN0cm95ID0gZHdfaGRtaV9jb25uZWN0b3Jf ZGVzdHJveSwKPj4gICAJLmZvcmNlID0gZHdfaGRtaV9jb25uZWN0b3JfZm9yY2UsCj4+ICsJLnJl c2V0ID0gZHJtX2F0b21pY19oZWxwZXJfY29ubmVjdG9yX3Jlc2V0LAo+PiArCS5hdG9taWNfZHVw bGljYXRlX3N0YXRlID0gZHJtX2F0b21pY19oZWxwZXJfY29ubmVjdG9yX2R1cGxpY2F0ZV9zdGF0 ZSwKPj4gKwkuYXRvbWljX2Rlc3Ryb3lfc3RhdGUgPSBkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0 b3JfZGVzdHJveV9zdGF0ZSwKPj4gICB9Owo+PiAgIAo+PiAgIHN0YXRpYyBzdHJ1Y3QgZHJtX2Nv bm5lY3Rvcl9oZWxwZXJfZnVuY3MgZHdfaGRtaV9jb25uZWN0b3JfaGVscGVyX2Z1bmNzID0gewo+ PiAtLSAKPj4gMS43LjkuNQo+Pgo+Pgo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwo+PiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4+IGRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Tue, 01 Dec 2015 16:07:02 +0800 Subject: [RFC PATCH 8/9] drm: bridge/dw_hdmi: Covert to support atomic API In-Reply-To: <20151201072128.GF17050@phenom.ffwll.local> References: <1448940391-23333-1-git-send-email-mark.yao@rock-chips.com> <1448940953-23604-1-git-send-email-mark.yao@rock-chips.com> <20151201072128.GF17050@phenom.ffwll.local> Message-ID: <565D5526.7030009@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?12?01? 15:21, Daniel Vetter wrote: > On Tue, Dec 01, 2015 at 11:35:53AM +0800, Mark Yao wrote: >> Fill atomic needed funcs with default atomic helper library. >> >> Rockchip use dw_hdmi, and drm/rockchip will covert to atomic api, >> we need dw_hdmi support atomic funcs. >> >> Signed-off-by: Mark Yao > Aren't there drivers around which use dw_hdmi and which are still not yet > atomic? This would break them. I think we neeed two connector_func tables > and dw_hdmi needs to check for DRIVER_ATOMIC at runtime and pick the right > version. Right, another drm driver use dw_hdmi is imx, not yet atomic, this would break it. as you said, I would resend a patch to check DRIVER_ATOMIC at runtime. Thanks -Mark > > The larger problem here is that "who should register the drm_connector" is > a bit an unsolved problem, since both the bridge and the driver should be > able to customize/adjust the drm_connector at the end of a bridge chain. > This here is just another example of this problem. > -Daniel > >> --- >> drivers/gpu/drm/bridge/dw_hdmi.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c >> index 56de9f1..587065a 100644 >> --- a/drivers/gpu/drm/bridge/dw_hdmi.c >> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c >> @@ -22,6 +22,7 @@ >> >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -1515,11 +1516,14 @@ static void dw_hdmi_connector_force(struct drm_connector *connector) >> } >> >> static struct drm_connector_funcs dw_hdmi_connector_funcs = { >> - .dpms = drm_helper_connector_dpms, >> + .dpms = drm_atomic_helper_connector_dpms, >> .fill_modes = drm_helper_probe_single_connector_modes, >> .detect = dw_hdmi_connector_detect, >> .destroy = dw_hdmi_connector_destroy, >> .force = dw_hdmi_connector_force, >> + .reset = drm_atomic_helper_connector_reset, >> + .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, >> + .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, >> }; >> >> static struct drm_connector_helper_funcs dw_hdmi_connector_helper_funcs = { >> -- >> 1.7.9.5 >> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel at lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755439AbbLAIHw (ORCPT ); Tue, 1 Dec 2015 03:07:52 -0500 Received: from regular1.263xmail.com ([211.150.99.130]:49829 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755300AbbLAIHu (ORCPT ); Tue, 1 Dec 2015 03:07:50 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: treding@nvidia.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <4087d1f0bd14fe2e0edf53e6e293ce10> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <565D5526.7030009@rock-chips.com> Date: Tue, 01 Dec 2015 16:07:02 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , Philipp Zabel , Andy Yan , Fabio Estevam , Thierry Reding Subject: Re: [RFC PATCH 8/9] drm: bridge/dw_hdmi: Covert to support atomic API References: <1448940391-23333-1-git-send-email-mark.yao@rock-chips.com> <1448940953-23604-1-git-send-email-mark.yao@rock-chips.com> <20151201072128.GF17050@phenom.ffwll.local> In-Reply-To: <20151201072128.GF17050@phenom.ffwll.local> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年12月01日 15:21, Daniel Vetter wrote: > On Tue, Dec 01, 2015 at 11:35:53AM +0800, Mark Yao wrote: >> Fill atomic needed funcs with default atomic helper library. >> >> Rockchip use dw_hdmi, and drm/rockchip will covert to atomic api, >> we need dw_hdmi support atomic funcs. >> >> Signed-off-by: Mark Yao > Aren't there drivers around which use dw_hdmi and which are still not yet > atomic? This would break them. I think we neeed two connector_func tables > and dw_hdmi needs to check for DRIVER_ATOMIC at runtime and pick the right > version. Right, another drm driver use dw_hdmi is imx, not yet atomic, this would break it. as you said, I would resend a patch to check DRIVER_ATOMIC at runtime. Thanks -Mark > > The larger problem here is that "who should register the drm_connector" is > a bit an unsolved problem, since both the bridge and the driver should be > able to customize/adjust the drm_connector at the end of a bridge chain. > This here is just another example of this problem. > -Daniel > >> --- >> drivers/gpu/drm/bridge/dw_hdmi.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c >> index 56de9f1..587065a 100644 >> --- a/drivers/gpu/drm/bridge/dw_hdmi.c >> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c >> @@ -22,6 +22,7 @@ >> >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -1515,11 +1516,14 @@ static void dw_hdmi_connector_force(struct drm_connector *connector) >> } >> >> static struct drm_connector_funcs dw_hdmi_connector_funcs = { >> - .dpms = drm_helper_connector_dpms, >> + .dpms = drm_atomic_helper_connector_dpms, >> .fill_modes = drm_helper_probe_single_connector_modes, >> .detect = dw_hdmi_connector_detect, >> .destroy = dw_hdmi_connector_destroy, >> .force = dw_hdmi_connector_force, >> + .reset = drm_atomic_helper_connector_reset, >> + .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, >> + .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, >> }; >> >> static struct drm_connector_helper_funcs dw_hdmi_connector_helper_funcs = { >> -- >> 1.7.9.5 >> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel