From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: usb: Rename the sunxi usb driver DM entry
Date: Tue, 1 Dec 2015 09:27:59 +0100 [thread overview]
Message-ID: <565D5A0F.5060608@redhat.com> (raw)
In-Reply-To: <1448903959-10289-1-git-send-email-marex@denx.de>
Hi,
On 30-11-15 18:19, Marek Vasut wrote:
> The DM entry should be unique, otherwise it will collide with other
> drivers. Fix this by assigning the driver a more unique name than
> usb_ehci.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Ian Campbell <ijc@hellion.org.uk>
> Cc: Simon Glass <sjg@chromium.org>
Looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Marek, do you want me to take this upstream through the
u-boot-sunxi tree, or will you pick this up yourself ?
Regards,
Hans
> ---
> drivers/usb/host/ehci-sunxi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-sunxi.c b/drivers/usb/host/ehci-sunxi.c
> index 38d5f92..d494ca1 100644
> --- a/drivers/usb/host/ehci-sunxi.c
> +++ b/drivers/usb/host/ehci-sunxi.c
> @@ -87,7 +87,7 @@ static const struct udevice_id ehci_usb_ids[] = {
> { }
> };
>
> -U_BOOT_DRIVER(usb_ehci) = {
> +U_BOOT_DRIVER(ehci_sunxi) = {
> .name = "ehci_sunxi",
> .id = UCLASS_USB,
> .of_match = ehci_usb_ids,
>
next prev parent reply other threads:[~2015-12-01 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 17:19 [U-Boot] [PATCH] sunxi: usb: Rename the sunxi usb driver DM entry Marek Vasut
2015-12-01 8:27 ` Hans de Goede [this message]
2015-12-01 13:13 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565D5A0F.5060608@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.