From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API Date: Tue, 01 Dec 2015 17:31:28 +0800 Message-ID: <565D68F0.3010905@rock-chips.com> References: <1448940391-23333-1-git-send-email-mark.yao@rock-chips.com> <1448940391-23333-4-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Stone Cc: Linux Kernel Mailing List , dri-devel , Tomasz Figa , linux-rockchip , "linux-arm-kernel@lists.infradead.org" List-Id: linux-rockchip.vger.kernel.org T24gMjAxNeW5tDEy5pyIMDHml6UgMTY6MTgsIERhbmllbCBTdG9uZSB3cm90ZToKPiBIaSBNYXJr LAo+Cj4gT24gMSBEZWNlbWJlciAyMDE1IGF0IDAzOjI2LCBNYXJrIFlhbzxtYXJrLnlhb0Byb2Nr LWNoaXBzLmNvbT4gIHdyb3RlOgo+PiA+K3N0YXRpYyB2b2lkIHJvY2tjaGlwX2F0b21pY193YWl0 X2Zvcl9jb21wbGV0ZShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4+ID4rewo+PiA+ KyAgICAgICBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4+ID4rICAgICAgIHN0 cnVjdCBkcm1fY3J0YyAqY3J0YzsKPj4gPisgICAgICAgaW50IGk7Cj4+ID4rCj4+ID4rICAgICAg IGZvcl9lYWNoX2NydGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIGNydGNfc3RhdGUsIGkpIHsKPj4g PisgICAgICAgICAgICAgICBpZiAoIWNydGMtPnN0YXRlLT5hY3RpdmUpCj4+ID4rICAgICAgICAg ICAgICAgICAgICAgICBjb250aW51ZTsKPj4gPisKPj4gPisgICAgICAgICAgICAgICBXQVJOX09O KGRybV9jcnRjX3ZibGFua19nZXQoY3J0YykpOwo+PiA+KyAgICAgICB9Cj4+ID4rCj4+ID4rICAg ICAgIGZvcl9lYWNoX2NydGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIGNydGNfc3RhdGUsIGkpIHsK Pj4gPisgICAgICAgICAgICAgICBpZiAoIWNydGMtPnN0YXRlLT5hY3RpdmUpCj4+ID4rICAgICAg ICAgICAgICAgICAgICAgICBjb250aW51ZTsKPj4gPisKPj4gPisgICAgICAgICAgICAgICByb2Nr Y2hpcF9jcnRjX3dhaXRfZm9yX3VwZGF0ZShjcnRjKTsKPj4gPisgICAgICAgfQo+IEknZCBiZSBt dWNoIG1vcmUgY29tZm9ydGFibGUgaWYgdGhpcyBwYXNzZWQgaW4gYW4gZXhwbGljaXQgcG9pbnRl ciB0bwo+IHN0YXRlLCBvciBhbiBhZGRyZXNzIHRvIHdhaXQgZm9yLCByYXRoZXIgdGhhbiBoYXZl IHdhaXRfZm9yX2NvbXBsZXRlCj4gZGlnIG91dCBzdGF0ZSB3aXRoIG5vIGxvY2tpbmcuIFRoZSBs YXR0ZXIgaXMgcG90ZW50aWFsbHkgcmFjeSBmb3IKPiBhc3luYyBvcGVyYXRpb25zLgo+CkhpIERh bmllbAogICAgImlmIHRoaXMgcGFzc2VkIGluIGFuIGV4cGxpY2l0IHBvaW50ZXIgdG8gc3RhdGUs IG9yIGFuIGFkZHJlc3MgdG8gCndhaXQgZm9yIiwgSSBkb24ndCB1bmRlcnN0YW5kLCBjYW4geW91 IHBvaW50IGhvdyBpdCB3b3JrPwoKLS0gCu+8rWFyayBZYW8KCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Tue, 01 Dec 2015 17:31:28 +0800 Subject: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API In-Reply-To: References: <1448940391-23333-1-git-send-email-mark.yao@rock-chips.com> <1448940391-23333-4-git-send-email-mark.yao@rock-chips.com> Message-ID: <565D68F0.3010905@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?12?01? 16:18, Daniel Stone wrote: > Hi Mark, > > On 1 December 2015 at 03:26, Mark Yao wrote: >> >+static void rockchip_atomic_wait_for_complete(struct drm_atomic_state *state) >> >+{ >> >+ struct drm_crtc_state *crtc_state; >> >+ struct drm_crtc *crtc; >> >+ int i; >> >+ >> >+ for_each_crtc_in_state(state, crtc, crtc_state, i) { >> >+ if (!crtc->state->active) >> >+ continue; >> >+ >> >+ WARN_ON(drm_crtc_vblank_get(crtc)); >> >+ } >> >+ >> >+ for_each_crtc_in_state(state, crtc, crtc_state, i) { >> >+ if (!crtc->state->active) >> >+ continue; >> >+ >> >+ rockchip_crtc_wait_for_update(crtc); >> >+ } > I'd be much more comfortable if this passed in an explicit pointer to > state, or an address to wait for, rather than have wait_for_complete > dig out state with no locking. The latter is potentially racy for > async operations. > Hi Daniel "if this passed in an explicit pointer to state, or an address to wait for", I don't understand, can you point how it work? -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755895AbbLAJbj (ORCPT ); Tue, 1 Dec 2015 04:31:39 -0500 Received: from regular1.263xmail.com ([211.150.99.133]:34910 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755822AbbLAJbg (ORCPT ); Tue, 1 Dec 2015 04:31:36 -0500 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: tfiga@chromium.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <9511279f7fc94f36ad4fab15973db2a5> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <565D68F0.3010905@rock-chips.com> Date: Tue, 01 Dec 2015 17:31:28 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Daniel Stone CC: David Airlie , Heiko Stuebner , dri-devel , "linux-arm-kernel@lists.infradead.org" , linux-rockchip , Linux Kernel Mailing List , Tomasz Figa Subject: Re: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API References: <1448940391-23333-1-git-send-email-mark.yao@rock-chips.com> <1448940391-23333-4-git-send-email-mark.yao@rock-chips.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年12月01日 16:18, Daniel Stone wrote: > Hi Mark, > > On 1 December 2015 at 03:26, Mark Yao wrote: >> >+static void rockchip_atomic_wait_for_complete(struct drm_atomic_state *state) >> >+{ >> >+ struct drm_crtc_state *crtc_state; >> >+ struct drm_crtc *crtc; >> >+ int i; >> >+ >> >+ for_each_crtc_in_state(state, crtc, crtc_state, i) { >> >+ if (!crtc->state->active) >> >+ continue; >> >+ >> >+ WARN_ON(drm_crtc_vblank_get(crtc)); >> >+ } >> >+ >> >+ for_each_crtc_in_state(state, crtc, crtc_state, i) { >> >+ if (!crtc->state->active) >> >+ continue; >> >+ >> >+ rockchip_crtc_wait_for_update(crtc); >> >+ } > I'd be much more comfortable if this passed in an explicit pointer to > state, or an address to wait for, rather than have wait_for_complete > dig out state with no locking. The latter is potentially racy for > async operations. > Hi Daniel "if this passed in an explicit pointer to state, or an address to wait for", I don't understand, can you point how it work? -- Ｍark Yao