From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [RFC PATCH 2/9] drm/rockchip: Use new vblank api drm_crtc_vblank_* Date: Tue, 01 Dec 2015 17:43:24 +0800 Message-ID: <565D6BBC.20608@rock-chips.com> References: <1448940391-23333-1-git-send-email-mark.yao@rock-chips.com> <1448940391-23333-3-git-send-email-mark.yao@rock-chips.com> <565D5B57.4040102@rock-chips.com> <20151201090127.GN17050@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20151201090127.GN17050@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Stone , Linux Kernel Mailing List , dri-devel , linux-rockchip , "linux-arm-kernel@lists.infradead.org" List-Id: linux-rockchip.vger.kernel.org T24gMjAxNeW5tDEy5pyIMDHml6UgMTc6MDEsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gT24gVHVl LCBEZWMgMDEsIDIwMTUgYXQgMDQ6MzM6MjdQTSArMDgwMCwgTWFyayB5YW8gd3JvdGU6Cj4+IE9u IDIwMTXlubQxMuaciDAx5pelIDE1OjU2LCBEYW5pZWwgU3RvbmUgd3JvdGU6Cj4+PiBIaSwKPj4+ Cj4+PiBPbiAxIERlY2VtYmVyIDIwMTUgYXQgMDM6MjYsIE1hcmsgWWFvIDxtYXJrLnlhb0Byb2Nr LWNoaXBzLmNvbT4gd3JvdGU6Cj4+Pj4gTm8gZnVuY3Rpb25hbCB1cGRhdGUsIGRybV92Ymxhbmtf KiBpcyB0aGUgbGVnYWN5IHZlcnNpb24gb2YKPj4+PiBkcm1fY3J0Y192YmxhbmtfKi4gYW5kIHVz ZSBuZXcgYXBpIG1ha2UgZHJpdmVyIG1vcmUgY2xlYW4uCj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5 OiBNYXJrIFlhbyA8bWFyay55YW9Acm9jay1jaGlwcy5jb20+Cj4+PiBIZWgsIEkgaGFkIHRoZSBz YW1lIHBhdGNoIGluIG15IHNlcmllcyB0byBmaXggcGFnZWZsaXAgZXZlbnRzLgo+Pj4KPj4+IFJl dmlld2VkLWJ5OiBEYW5pZWwgU3RvbmUgPGRhbmllbHNAY29sbGFib3JhLmNvbT4KPj4+Cj4+PiBD aGVlcnMsCj4+PiBEYW5pZWwKPj4+Cj4+Pgo+Pj4KPj4gSGkgRGFuaWVsCj4+ICAgICBJIGhhZCBw aWNrZWQgeW91ciBwYXRjaCAiW1BBVENIIDEvMl0gZHJtL3JvY2tjaGlwOiBVc2UgQ1JUQyB2Ymxh bmsgZXZlbnQKPj4gaW50ZXJmYWNlIiBpbnRvIG15IGRybS1uZXh0LCB0aGlzIHBhdGNoIGlzIGJh c2Ugb24gaXQuCj4gVGhhdCByZWFsbHkgc2hvdWxkIGJlIG1lbnRpb25lZCBpbiB0aGUgY29tbWl0 IG1lc3NhZ2UsIGFuZCB5b3UgbXVzdCBrZWVwCj4gdGhlIHNpZ25lZC1vZmYtYnkgY2hhaW4gaW50 YWN0IHdoZW4gYWRhcHRpbmcgb3IgcmV1c2luZyBvdGhlciBwZW9wbGVzCj4gd29yay4KPiAtRGFu aWVsCgpPaCwgU29ycnkgZm9yIHRoYXQsIHRoaXMgcGF0Y2ggaXMgYW5vdGhlciBwYXRjaCByZWJh c2Ugb24gRGFuaWVsIFN0b25lJ3MgCm9uZSwgSSB1c2UgImJhc2Ugb24gaXQiIG1heSBiZSBhbWJp Z3VpdHkuCmxpa2UgdGhhdDoKMGU2OTE5ZiBkcm0vcm9ja2NoaXA6IFVzZSBuZXcgdmJsYW5rIGFw aSBkcm1fY3J0Y192YmxhbmtfKgo0ZjBjYjdjIGRybS9yb2NrY2hpcDogVXNlIENSVEMgdmJsYW5r IGV2ZW50IGludGVyZmFjZQoKVGhhbmtzIGZvciBwb2ludGluZyB0aGF0LCBJIHdpbGwgYmUgY2Fy ZWZ1bGx5IG5leHQgdGltZS4KCj4+IFRoYW5rcyBmb3IgeW91ciByZXZpZXcuCj4+Cj4+IC0tIAo+ PiDvvK1hcmsgWWFvCj4+Cj4+Cj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPj4gZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+PiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Tue, 01 Dec 2015 17:43:24 +0800 Subject: [RFC PATCH 2/9] drm/rockchip: Use new vblank api drm_crtc_vblank_* In-Reply-To: <20151201090127.GN17050@phenom.ffwll.local> References: <1448940391-23333-1-git-send-email-mark.yao@rock-chips.com> <1448940391-23333-3-git-send-email-mark.yao@rock-chips.com> <565D5B57.4040102@rock-chips.com> <20151201090127.GN17050@phenom.ffwll.local> Message-ID: <565D6BBC.20608@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?12?01? 17:01, Daniel Vetter wrote: > On Tue, Dec 01, 2015 at 04:33:27PM +0800, Mark yao wrote: >> On 2015?12?01? 15:56, Daniel Stone wrote: >>> Hi, >>> >>> On 1 December 2015 at 03:26, Mark Yao wrote: >>>> No functional update, drm_vblank_* is the legacy version of >>>> drm_crtc_vblank_*. and use new api make driver more clean. >>>> >>>> Signed-off-by: Mark Yao >>> Heh, I had the same patch in my series to fix pageflip events. >>> >>> Reviewed-by: Daniel Stone >>> >>> Cheers, >>> Daniel >>> >>> >>> >> Hi Daniel >> I had picked your patch "[PATCH 1/2] drm/rockchip: Use CRTC vblank event >> interface" into my drm-next, this patch is base on it. > That really should be mentioned in the commit message, and you must keep > the signed-off-by chain intact when adapting or reusing other peoples > work. > -Daniel Oh, Sorry for that, this patch is another patch rebase on Daniel Stone's one, I use "base on it" may be ambiguity. like that: 0e6919f drm/rockchip: Use new vblank api drm_crtc_vblank_* 4f0cb7c drm/rockchip: Use CRTC vblank event interface Thanks for pointing that, I will be carefully next time. >> Thanks for your review. >> >> -- >> ?ark Yao >> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel at lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755979AbbLAJnk (ORCPT ); Tue, 1 Dec 2015 04:43:40 -0500 Received: from regular1.263xmail.com ([211.150.99.137]:48434 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755677AbbLAJnh (ORCPT ); Tue, 1 Dec 2015 04:43:37 -0500 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <565D6BBC.20608@rock-chips.com> Date: Tue, 01 Dec 2015 17:43:24 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Daniel Stone , Linux Kernel Mailing List , dri-devel , linux-rockchip , "linux-arm-kernel@lists.infradead.org" Subject: Re: [RFC PATCH 2/9] drm/rockchip: Use new vblank api drm_crtc_vblank_* References: <1448940391-23333-1-git-send-email-mark.yao@rock-chips.com> <1448940391-23333-3-git-send-email-mark.yao@rock-chips.com> <565D5B57.4040102@rock-chips.com> <20151201090127.GN17050@phenom.ffwll.local> In-Reply-To: <20151201090127.GN17050@phenom.ffwll.local> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年12月01日 17:01, Daniel Vetter wrote: > On Tue, Dec 01, 2015 at 04:33:27PM +0800, Mark yao wrote: >> On 2015年12月01日 15:56, Daniel Stone wrote: >>> Hi, >>> >>> On 1 December 2015 at 03:26, Mark Yao wrote: >>>> No functional update, drm_vblank_* is the legacy version of >>>> drm_crtc_vblank_*. and use new api make driver more clean. >>>> >>>> Signed-off-by: Mark Yao >>> Heh, I had the same patch in my series to fix pageflip events. >>> >>> Reviewed-by: Daniel Stone >>> >>> Cheers, >>> Daniel >>> >>> >>> >> Hi Daniel >> I had picked your patch "[PATCH 1/2] drm/rockchip: Use CRTC vblank event >> interface" into my drm-next, this patch is base on it. > That really should be mentioned in the commit message, and you must keep > the signed-off-by chain intact when adapting or reusing other peoples > work. > -Daniel Oh, Sorry for that, this patch is another patch rebase on Daniel Stone's one, I use "base on it" may be ambiguity. like that: 0e6919f drm/rockchip: Use new vblank api drm_crtc_vblank_* 4f0cb7c drm/rockchip: Use CRTC vblank event interface Thanks for pointing that, I will be carefully next time. >> Thanks for your review. >> >> -- >> Ｍark Yao >> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel