All of lore.kernel.org
 help / color / mirror / Atom feed
From: Moise Gergaud <moise.gergaud@st.com>
To: Mark Brown <broonie@kernel.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
	arnaud.pouliquen@st.com, lgirdwood@gmail.com
Subject: Re: [PATCH 2/2] ASoC: sti: correction for HBRA support
Date: Tue, 1 Dec 2015 10:52:14 +0100	[thread overview]
Message-ID: <565D6DCE.50906@st.com> (raw)
In-Reply-To: <20151130163057.GA1929@sirena.org.uk>

On 11/30/2015 05:30 PM, Mark Brown wrote:
> On Tue, Nov 24, 2015 at 02:16:36PM +0100, Moise Gergaud wrote:
>> Detect HBRA based on rate and channels used in the pcm session
>> In case of HBRA:
>>    - CH_STS repeat is disabled
>>    - channel status sampling freq is not set if already set (because it can
>>      be a multiple of the runtime rate)
>
> You might want to expand HBRA...
you mean in term of frequency?
>
>>   		switch (runtime->rate) {
>>   		case 22050:
>> -			player->stream_settings.iec958.status[3] =
>> -						IEC958_AES3_CON_FS_22050;
>> +			*aes3 |= IEC958_AES3_CON_FS_22050;
>>   			break;
>
> This feels like someting we could have as a generic function for other
> drivers to use - can you add a core function and then call it from your
> driver please?
>
yes, I will add something like snd_pcm_update_iec958_consumer to update 
fs and ws.

  reply	other threads:[~2015-12-01  9:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24 13:16 [PATCH 0/2] correction of iec958 channel status sampling freq setting Moise Gergaud
2015-11-24 13:16 ` [PATCH 1/2] ASoC: sti: set iec958 channel status sampling freq Moise Gergaud
2015-11-25 13:00   ` Applied "ASoC: sti: set iec958 channel status sampling freq" to the asoc tree Mark Brown
2015-11-24 13:16 ` [PATCH 2/2] ASoC: sti: correction for HBRA support Moise Gergaud
2015-11-30 16:30   ` Mark Brown
2015-12-01  9:52     ` Moise Gergaud [this message]
2015-12-01 11:35       ` Mark Brown
2015-12-01 12:27         ` Moise Gergaud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565D6DCE.50906@st.com \
    --to=moise.gergaud@st.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnaud.pouliquen@st.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.