All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: Or Gerlitz <gerlitz.or@gmail.com>, Sagi Grimberg <sagig@mellanox.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	target-devel@vger.kernel.org,
	"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
	Or Gerlitz <ogerlitz@mellanox.com>,
	Jenny Derzhavetz <jennyf@mellanox.com>,
	Steve Wise <swise@opengridcomputing.com>
Subject: Re: [PATCH v1 10/10] IB/iser: Support the remote invalidation exception
Date: Tue, 1 Dec 2015 12:43:41 +0200	[thread overview]
Message-ID: <565D79DD.7060600@dev.mellanox.co.il> (raw)
In-Reply-To: <CAJ3xEMjqhCMZz=dX91vzzi20F8P1Tjh=WA2MKwBQ5G7OR8mn5Q@mail.gmail.com>



On 30/11/2015 23:36, Or Gerlitz wrote:
> On Tue, Nov 24, 2015 at 6:23 PM, Sagi Grimberg <sagig@mellanox.com> wrote:
>>
>> From: Jenny Derzhavetz <jennyf@mellanox.com>
>>
>> Declare that we support remote invalidation in case we are:
>> 1. using Fastreg method
>> 2. always registering memory.
>
> decide if you want or don't want to use periods @ the end of these
> cases, but be consistent... I vote not to use periods

I'll fix.

>
>>
>> Detect the invalidated rkey from the work completion info so we
>> won't invalidate it locally. The spec madates that we must not rely
>> on the taget remote invalidate our rkey so we must check it upon
>> a receive (scsi response) completion.
>>
>
> s/madates/mandates/ and run spell check over the change-logs of the
> whole series please before posting v2

OK.

Thanks Or

  reply	other threads:[~2015-12-01 10:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 21:36 [PATCH v1 10/10] IB/iser: Support the remote invalidation exception Or Gerlitz
2015-12-01 10:43 ` Sagi Grimberg [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-11-24 16:23 [PATCH v1 00/10] iSER support for remote invalidate Sagi Grimberg
2015-11-24 16:23 ` [PATCH v1 10/10] IB/iser: Support the remote invalidation exception Sagi Grimberg
     [not found]   ` <1448382234-24806-11-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-30 13:27     ` Haggai Eran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565D79DD.7060600@dev.mellanox.co.il \
    --to=sagig@dev.mellanox.co.il \
    --cc=gerlitz.or@gmail.com \
    --cc=jennyf@mellanox.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=ogerlitz@mellanox.com \
    --cc=sagig@mellanox.com \
    --cc=swise@opengridcomputing.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.