All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] fdtgrep exclude nodes
Date: Tue, 1 Dec 2015 14:31:18 +0100	[thread overview]
Message-ID: <565DA126.30307@denx.de> (raw)
In-Reply-To: <565D9EFF.3040301@monstr.eu>

On 01.12.2015 14:22, Michal Simek wrote:
> On 1.12.2015 11:46, Stefan Roese wrote:
>> Hi Michal,
>>
>> On 01.12.2015 11:21, Michal Simek wrote:
>>> I was checking spl/u-boot-spl.dtb and I see that you are removing
>>> interrupt-parent property but I think that also make sense to remove
>>> interrupt property as well because it is unused and parent is also
>>> removed.
>>> Just extend OF_SPL_REMOVE_PROPS by "interrupts" to save some memory.
>>
>> I'm fine with this.
>>
>>> Another thing I was checking was that we are missing rules for removing
>>> nodes with status = "disabled" property. I think that will be good to
>>> add it. The reason is that I would move all that u-boot,dm-pre-reloc to
>>> dtsi at least for now.
>>
>> Hmmm. I prefer to add this "u-boot,dm-pre-reloc" to the board dts
>> file instead of using the dtsi files. At least for the real devices,
>> like UART etc. As they vary between the different boards.
>
> How do you handle if you have 2 uarts which one is primary one?
> That only one has dm-pre-reloc? Or are you using aliases?

I only mark the devices absolutely necessary in SPL for booting
with dm-pre-reloc. And that only one UART, one SPI NOR etc.
And yes, I'm also using aliases.

>
>> Perhaps its possible to enable those busses (simple-bus) needed
>> to traverse to the requested device automatically via fdtgrep?
>> That would make this much easier and less error-prone. And would
>> result in less "u-boot,dm-pre-reloc" occurances in the dts / dtsi
>> files.
>
> I still think that instead of putting this property to every node having
> one property with list of devices in chosen node is better way.

Yes, that would also be a good solution. Sprinkling these pre-reloc
properties all over the files and nodes / busses is definitely
not perfect.

Thanks,
Stefan

  reply	other threads:[~2015-12-01 13:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01 10:21 [U-Boot] fdtgrep exclude nodes Michal Simek
2015-12-01 10:46 ` Stefan Roese
2015-12-01 13:22   ` Michal Simek
2015-12-01 13:31     ` Stefan Roese [this message]
2015-12-01 13:43       ` Simon Glass
2015-12-01 13:43       ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565DA126.30307@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.