Re: [Qemu-devel] [PATCH v3 10/12] Dump: add qmp command "query-dump"

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

On 11/30/2015 09:40 PM, Peter Xu wrote:

>>> +++ b/qmp-commands.hx
>>> @@ -881,7 +881,7 @@ EQMP
>>>      {
>>>          .name       = "query-dump-guest-memory-capability",
>>>          .args_type  = "",
>>> -    .mhandler.cmd_new = qmp_marshal_query_dump_guest_memory_capability,
>>> +        .mhandler.cmd_new = qmp_marshal_query_dump_guest_memory_capability,
>>>      },
>>
>> Unrelated hunk.
> 
> Is it ok to have this line here? I just saw it and fixed it. Please
> let me know if I should move it out of this patch.

It's small enough that you could separate that hunk into its own patch
and cc qemu-trivial.

As it is, Marc-Andre has queued patches that get rid of qmp-commands.hx;
so if Markus and I can get through the backlog of qapi patches, this
problem may just disappear on its own.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]