Re: CodingStyle on existing code

[Wido den Hollander <wido@42on.com>]

On 01-12-15 16:00, Gregory Farnum wrote:
> On Tue, Dec 1, 2015 at 5:47 AM, Loic Dachary <loic@dachary.org> wrote:
>>
>>
>> On 01/12/2015 14:10, Wido den Hollander wrote:
>>> Hi,
>>>
>>> While working on mon/PGMonitor.cc I see that there is a lot of
>>> inconsistency on the code.
>>>
>>> A lot of whitespaces, indentation which is not correct, well, a lot of
>>> things.
>>>
>>> Is this something we want to fix? With some scripts we can probably do
>>> this easily, but it might cause merge hell with people working on features.
>>
>> A sane (but long) way to do that is to cleanup when fixing a bug or adding a feature. With (a lot) of patience, it will eventually be better :-)
> 
> Yeah, we generally want you to follow the standards in any new code. A
> mass update of the code style on existing code makes navigating the
> history a little harder so a lot of people don't like it much, though.

Understood. But in this case I'm working in PGMonitor.cc. For just 20
lines of code I probably shouldn't refactor the whole file, should I?

> *shrug*
> -Greg
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>