Re: [Qemu-devel] [PATCH 5/5] qmp: create QMP implementation of loadvm command

["Denis V. Lunev" <den@openvz.org>]

On 11/18/2015 02:41 PM, Juan Quintela wrote:
> "Denis V. Lunev" <den@openvz.org> wrote:
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Juan Quintela <quintela@redhat.com>
>> CC: Amit Shah <amit.shah@redhat.com>
>> CC: Markus Armbruster <armbru@redhat.com>
>> CC: Eric Blake <eblake@redhat.com>
>> ---
>>   migration/savevm.c |  5 +++++
>>   qapi-schema.json   | 13 +++++++++++++
>>   qmp-commands.hx    | 23 +++++++++++++++++++++++
>>   3 files changed, 41 insertions(+)
>>
>> diff --git a/migration/savevm.c b/migration/savevm.c
>> index 08c6c65..f67b5d9 100644
>> --- a/migration/savevm.c
>> +++ b/migration/savevm.c
>> @@ -2116,6 +2116,11 @@ int load_vmstate(const char *name, Error **errp)
>>       return 0;
>>   }
>>   
>> +void qmp_loadvm(const char *name, Error **errp)
>> +{
>> +    load_vmstate(name, errp);
>> +}
>> +
> As Markus suggested for the other functions,  rename load_vmstate qmp_loadvm()
>
> Thanks, Juan.
load_vmstate is actually 'int load_vmstate' and return
code is checked in qemu_img.c

Should I replace error code check there with a check
to *errp != 0 or this would lead us into a problem
with block level guys?

Den