From: Eric Sandeen <sandeen@sandeen.net>
To: Jeff Moyer <jmoyer@redhat.com>, fstests@vger.kernel.org
Subject: Re: [patch] make sure to _require_attrs when necessary
Date: Tue, 1 Dec 2015 11:43:50 -0600 [thread overview]
Message-ID: <565DDC56.9000901@sandeen.net> (raw)
In-Reply-To: <x49two2kr5r.fsf@segfault.boston.devel.redhat.com>
On 12/1/15 11:36 AM, Jeff Moyer wrote:
> xfs/073 and xfs/295 forgot to _require_attrs. Fix it.
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
thanks!
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
>
> diff --git a/tests/xfs/073 b/tests/xfs/073
> index 32faffd..9def3c6 100755
> --- a/tests/xfs/073
> +++ b/tests/xfs/073
> @@ -33,6 +33,7 @@ status=1 # failure is the default!
> # get standard environment, filters and checks
> . ./common/rc
> . ./common/filter
> +. ./common/attr
>
> # don't put fs images in /tmp
> imgs=$TEST_DIR/$$
> @@ -127,6 +128,7 @@ _verify_copy()
> _supported_fs xfs
> _supported_os Linux
> _require_test
> +_require_attrs
>
> [ "$USE_EXTERNAL" = yes ] && _notrun "Cannot xfs_copy with external devices"
> [ -n "$XFS_COPY_PROG" ] || _notrun "xfs_copy binary not yet installed"
> diff --git a/tests/xfs/295 b/tests/xfs/295
> index 79f27bd..2325537 100755
> --- a/tests/xfs/295
> +++ b/tests/xfs/295
> @@ -39,6 +39,7 @@ _cleanup()
> # get standard environment, filters and checks
> . ./common/rc
> . ./common/filter
> +. ./common/attr
>
> # real QA test starts here
>
> @@ -46,6 +47,7 @@ _cleanup()
> _supported_fs xfs
> _supported_os IRIX Linux
> _require_scratch
> +_require_attrs
>
> rm -f $seqres.full
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2015-12-01 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 17:36 [patch] make sure to _require_attrs when necessary Jeff Moyer
2015-12-01 17:43 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565DDC56.9000901@sandeen.net \
--to=sandeen@sandeen.net \
--cc=fstests@vger.kernel.org \
--cc=jmoyer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.