From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH v2] nvme: temporary fix for Apple controller reset
Date: Tue, 1 Dec 2015 12:56:47 -0700 [thread overview]
Message-ID: <565DFB7F.6000807@kernel.dk> (raw)
In-Reply-To: <9cc23b98072a89f0f469f528f6e8f74e@localhost>
On 12/01/2015 12:46 PM, Stephan G?nther wrote:
> The patch below has been reviewed by Christoph and reported to work.
> However, there is still no sign that it will be applied to linux-4.4.
>
> Please either undo commit c74dc7801d515d01847fd5cf2b472489fa5717b1,
> which added the PCI ID of the Apple controller, or merge the patch below
> asap.
>
>
> Currently, the driver will make that controller destroy data!
Honestly, I'd rather revert the pci id addition, unless there's
conclusive evidence that limiting the (per queue) depth to 2 really does
fix the issue. Is this what the OSX driver does? What testing was done
to ascertain that 2 is the magic number? Does it just make it harder to
hit, or does it really fix it?
--
Jens Axboe
next prev parent reply other threads:[~2015-12-01 19:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-22 2:28 [PATCH v2] nvme: temporary fix for Apple controller reset Stephan Günther
2015-11-22 8:56 ` Christoph Hellwig
2015-11-25 0:21 ` Wes Cilldhaire
2015-12-01 19:46 ` Stephan Günther
2015-12-01 19:56 ` Jens Axboe [this message]
2015-12-01 20:05 ` Stephan Günther
2015-12-01 20:10 ` Stephan Günther
2015-12-01 20:21 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565DFB7F.6000807@kernel.dk \
--to=axboe@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.