From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by kanga.kvack.org (Postfix) with ESMTP id 5944E6B0038 for ; Tue, 1 Dec 2015 15:56:17 -0500 (EST) Received: by pabfh17 with SMTP id fh17so16927659pab.0 for ; Tue, 01 Dec 2015 12:56:17 -0800 (PST) Received: from mga03.intel.com (mga03.intel.com. [134.134.136.65]) by mx.google.com with ESMTP id wj8si19228490pab.47.2015.12.01.12.56.16 for ; Tue, 01 Dec 2015 12:56:16 -0800 (PST) Subject: Re: [PATCH 6/9] rmap: support file THP References: <1447889136-6928-1-git-send-email-kirill.shutemov@linux.intel.com> <1447889136-6928-7-git-send-email-kirill.shutemov@linux.intel.com> From: Dave Hansen Message-ID: <565E096D.7000105@intel.com> Date: Tue, 1 Dec 2015 12:56:13 -0800 MIME-Version: 1.0 In-Reply-To: <1447889136-6928-7-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" , Hugh Dickins , Andrea Arcangeli , Andrew Morton Cc: Vlastimil Babka , Christoph Lameter , Naoya Horiguchi , Jerome Marchand , linux-kernel@vger.kernel.org, linux-mm@kvack.org On 11/18/2015 03:25 PM, Kirill A. Shutemov wrote: > -void page_add_file_rmap(struct page *page) > +void page_add_file_rmap(struct page *page, bool compound) I take it we have to pass 'compound' in explicitly because PageCompound() could be true, but we don't want to do a compound mapping. This is true for those weirdo sound driver allocations and a few other ones, right? Or is there something else? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756871AbbLAU41 (ORCPT ); Tue, 1 Dec 2015 15:56:27 -0500 Received: from mga02.intel.com ([134.134.136.20]:25648 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756386AbbLAU40 (ORCPT ); Tue, 1 Dec 2015 15:56:26 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,370,1444719600"; d="scan'208";a="5728562" Subject: Re: [PATCH 6/9] rmap: support file THP To: "Kirill A. Shutemov" , Hugh Dickins , Andrea Arcangeli , Andrew Morton References: <1447889136-6928-1-git-send-email-kirill.shutemov@linux.intel.com> <1447889136-6928-7-git-send-email-kirill.shutemov@linux.intel.com> Cc: Vlastimil Babka , Christoph Lameter , Naoya Horiguchi , Jerome Marchand , linux-kernel@vger.kernel.org, linux-mm@kvack.org From: Dave Hansen Message-ID: <565E096D.7000105@intel.com> Date: Tue, 1 Dec 2015 12:56:13 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447889136-6928-7-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/18/2015 03:25 PM, Kirill A. Shutemov wrote: > -void page_add_file_rmap(struct page *page) > +void page_add_file_rmap(struct page *page, bool compound) I take it we have to pass 'compound' in explicitly because PageCompound() could be true, but we don't want to do a compound mapping. This is true for those weirdo sound driver allocations and a few other ones, right? Or is there something else?