From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH] drm/rockchip: Fix module autoload for OF platform driver Date: Wed, 02 Dec 2015 08:57:08 +0800 Message-ID: <565E41E4.4060606@rock-chips.com> References: <1448895416-9502-1-git-send-email-luisbg@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1448895416-9502-1-git-send-email-luisbg@osg.samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Luis de Bethencourt , linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxNeW5tDEx5pyIMzDml6UgMjI6NTYsIEx1aXMgZGUgQmV0aGVuY291cnQgd3JvdGU6Cj4g VGhpcyBwbGF0Zm9ybSBkcml2ZXIgaGFzIGEgT0YgZGV2aWNlIElEIHRhYmxlIGJ1dCB0aGUgT0Yg bW9kdWxlCj4gYWxpYXMgaW5mb3JtYXRpb24gaXMgbm90IGNyZWF0ZWQgc28gbW9kdWxlIGF1dG9s b2FkaW5nIHdvbid0IHdvcmsuCj4KPiBTaWduZWQtb2ZmLWJ5OiBMdWlzIGRlIEJldGhlbmNvdXJ0 IDxsdWlzYmdAb3NnLnNhbXN1bmcuY29tPgo+IC0tLQo+Cj4gSGksCj4KPiBUaGlzIGlzIGEgUmVz ZW5kIG9mIGEgcGF0Y2ggZnJvbSBPY3RvYmVyIDIwdGggWzBdCj4KPiBJIGFtIGFkZGluZyBBbmRy ZXcgTW9ydG9uIHRvIHRoZSBDQyBsaXN0IGFzIHdhcyByZWNvbW1lbmRlZCBhdCB0aGUgS29yZWEg TGludXgKPiBGb3J1bS4KPgo+IFRoaXMgcGF0Y2ggYWRkcyB0aGUgbWlzc2luZyBNT0RVTEVfREVW SUNFX1RBQkxFKCkgZm9yIE9GIHRvIGV4cG9ydAo+IHRoYXQgaW5mb3JtYXRpb24gc28gbW9kdWxl cyBoYXZlIHRoZSBjb3JyZWN0IGFsaWFzZXMgYnVpbHQtaW4gYW5kCj4gYXV0b2xvYWRpbmcgd29y a3MgY29ycmVjdGx5Lgo+Cj4gQSBsb25nZXIgZXhwbGFuYXRpb24gYnkgSmF2aWVyIENhbmlsbGFz IGNhbiBiZSBmb3VuZCBoZXJlOgo+IGh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDE1LzcvMzAvNTE5 Cj4gQSBtdWx0aXR1ZGUgb2Ygc2ltaWxhciBwYXRjaGVzIGhhdmUgYmVlbiBtZXJnZWQgZm9yIG90 aGVyIGRyaXZlcnMsIHNlYXJjaAo+IHRoZSBnaXQgbG9nIGZvciAibW9kdWxlIGF1dG9sb2FkIGZv ciBPRiBwbGF0Zm9ybSBkcml2ZXIiLgo+Cj4gVGhhbmtzLAo+IEx1aXMKPgo+IFswXSBodHRwczov L2xrbWwub3JnL2xrbWwvMjAxNS8xMC8yMC80ODUKPgo+ICAgZHJpdmVycy9ncHUvZHJtL3JvY2tj aGlwL3JvY2tjaGlwX2RybV92b3AuYyB8IDEgKwo+ICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlw X2RybV92b3AuYyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmMK PiBpbmRleCA1ZDhhZTVlLi41ODk3ODUxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9y b2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2No aXAvcm9ja2NoaXBfZHJtX3ZvcC5jCj4gQEAgLTM3NCw2ICszNzQsNyBAQCBzdGF0aWMgY29uc3Qg c3RydWN0IG9mX2RldmljZV9pZCB2b3BfZHJpdmVyX2R0X21hdGNoW10gPSB7Cj4gICAJICAuZGF0 YSA9ICZyazMyODhfdm9wIH0sCj4gICAJe30sCj4gICB9Owo+ICtNT0RVTEVfREVWSUNFX1RBQkxF KG9mLCB2b3BfZHJpdmVyX2R0X21hdGNoKTsKPiAgIAo+ICAgc3RhdGljIGlubGluZSB2b2lkIHZv cF93cml0ZWwoc3RydWN0IHZvcCAqdm9wLCB1aW50MzJfdCBvZmZzZXQsIHVpbnQzMl90IHYpCj4g ICB7CkFwcGxpZWQgdG8gbXkgZHJtLWZpeGVzLCBUaGFua3MgZm9yIHRoaXMgZml4LgoKLS0gCu+8 rWFyayBZYW8KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Wed, 02 Dec 2015 08:57:08 +0800 Subject: [PATCH] drm/rockchip: Fix module autoload for OF platform driver In-Reply-To: <1448895416-9502-1-git-send-email-luisbg@osg.samsung.com> References: <1448895416-9502-1-git-send-email-luisbg@osg.samsung.com> Message-ID: <565E41E4.4060606@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?11?30? 22:56, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt > --- > > Hi, > > This is a Resend of a patch from October 20th [0] > > I am adding Andrew Morton to the CC list as was recommended at the Korea Linux > Forum. > > This patch adds the missing MODULE_DEVICE_TABLE() for OF to export > that information so modules have the correct aliases built-in and > autoloading works correctly. > > A longer explanation by Javier Canillas can be found here: > https://lkml.org/lkml/2015/7/30/519 > A multitude of similar patches have been merged for other drivers, search > the git log for "module autoload for OF platform driver". > > Thanks, > Luis > > [0] https://lkml.org/lkml/2015/10/20/485 > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 5d8ae5e..5897851 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -374,6 +374,7 @@ static const struct of_device_id vop_driver_dt_match[] = { > .data = &rk3288_vop }, > {}, > }; > +MODULE_DEVICE_TABLE(of, vop_driver_dt_match); > > static inline void vop_writel(struct vop *vop, uint32_t offset, uint32_t v) > { Applied to my drm-fixes, Thanks for this fix. -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757343AbbLBA5U (ORCPT ); Tue, 1 Dec 2015 19:57:20 -0500 Received: from regular1.263xmail.com ([211.150.99.134]:33800 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932249AbbLBA5T (ORCPT ); Tue, 1 Dec 2015 19:57:19 -0500 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: akpm@linux-foundation.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <0ee886ed5ec6b231f8e8de5ea8cfbeda> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <565E41E4.4060606@rock-chips.com> Date: Wed, 02 Dec 2015 08:57:08 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Luis de Bethencourt , linux-kernel@vger.kernel.org CC: airlied@linux.ie, heiko@sntech.de, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, akpm@linux-foundation.org Subject: Re: [PATCH] drm/rockchip: Fix module autoload for OF platform driver References: <1448895416-9502-1-git-send-email-luisbg@osg.samsung.com> In-Reply-To: <1448895416-9502-1-git-send-email-luisbg@osg.samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年11月30日 22:56, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt > --- > > Hi, > > This is a Resend of a patch from October 20th [0] > > I am adding Andrew Morton to the CC list as was recommended at the Korea Linux > Forum. > > This patch adds the missing MODULE_DEVICE_TABLE() for OF to export > that information so modules have the correct aliases built-in and > autoloading works correctly. > > A longer explanation by Javier Canillas can be found here: > https://lkml.org/lkml/2015/7/30/519 > A multitude of similar patches have been merged for other drivers, search > the git log for "module autoload for OF platform driver". > > Thanks, > Luis > > [0] https://lkml.org/lkml/2015/10/20/485 > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 5d8ae5e..5897851 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -374,6 +374,7 @@ static const struct of_device_id vop_driver_dt_match[] = { > .data = &rk3288_vop }, > {}, > }; > +MODULE_DEVICE_TABLE(of, vop_driver_dt_match); > > static inline void vop_writel(struct vop *vop, uint32_t offset, uint32_t v) > { Applied to my drm-fixes, Thanks for this fix. -- Ｍark Yao