From: "H. Peter Anvin" <hpa@zytor.com>
To: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>,
"joseph.cihula@intel.com" <joseph.cihula@intel.com>,
"richard.l.maliszewski@intel.com"
<richard.l.maliszewski@intel.com>,
"gang.wei@intel.com" <gang.wei@intel.com>,
"shane.wang@intel.com" <shane.wang@intel.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"x86@kernel.org" <x86@kernel.org>,
"tboot-devel@lists.sourceforge.net"
<tboot-devel@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Knippers, Linda" <linda.knippers@hpe.com>,
"Kani, Toshimitsu" <toshi.kani@hpe.com>
Subject: Re: tboot: non-0 tboot_addr but it is not of type E820_RESERVED
Date: Tue, 1 Dec 2015 18:20:06 -0800 [thread overview]
Message-ID: <565E5556.5040703@zytor.com> (raw)
In-Reply-To: <94D0CD8314A33A4D9D801C0FE68B40295BE775BC@G4W3202.americas.hpqcorp.net>
On 12/01/15 17:26, Elliott, Robert (Persistent Memory) wrote:
>
> Per an hpa suggestion, I compared two versions of grub:
>
> upstream grub (with "linux" in grub.cfg):
> tboot_probe boot_params[0] = 0000008000000000 0000000000000070
> tboot_probe boot_params[16] = 1000000400032000 0000009100003000
> tboot_probe boot_params[32] = 3fa3001000100810 0808080008180000
> tboot_probe boot_params[48] = 0000000000000000 0000000000000000
> tboot probe boot_params[64] = 0000000000000000 0000000000000000
> tboot_probe boot_params[80] = 0000000000000000 0000000000000000
> tboot_probe boot_params[96] = 0000000000000000 0000000000000000
> tboot_probe boot_params[112] = 0000000000000000 0000000000000000
> tboot_probe boot_params[128] = 0000000000000000 0000000000000000
> tboot_probe boot_params[144] = 0000000000000000 0000000000000000
> tboot_probe boot_params[160] = 0000000000000000 0000000000000000
> tboot_probe boot_params[176] = 0000000000000000 0000000000000000
> tboot_probe boot_params[192] = 0000000000000000 0000000000000000
> ...
> <no complaint about tboot_addr>
>
> Fedora 22 grub (with "linuxefi" in grub.cfg):
> tboot_probe boot_params[0] = 0000000000000000 0000000000000070
> tboot_probe boot_params[16] = 0000000400032000 0000009100003000
> tboot_probe boot_params[32] = 0000000000100810 0808080008180000
> tboot_probe boot_params[48] = 0000010000000100 0000000000000000
> tboot_probe boot_params[64] = 557365206120626f 6f74206c6f616465
> tboot_probe boot_params[80] = 722e0d0a0a52656d 6f7665206469736b
> tboot_probe boot_params[96] = 20616e6420707265 737320616e79206b
> tboot_probe boot_params[112] = 657920746f207265 626f6f742e2e2e0d
> tboot_probe boot_params[128] = 0a00504500006486 0400000000000000
> tboot_probe boot_params[144] = 000001000000a000 06020b020214f017
> tboot_probe boot_params[160] = 5c00000000001076 d200104600000002
> tboot_probe boot_params[176] = 0000000000000000 0000200000002000
> tboot_probe boot_params[192] = 0000000000000000 0000000000000000
> ...
> [ 0.000000] tboot: non-0 tboot_addr 0x6b7369642065766f but it is not of type E820_RESERVED
>
> In both cases, the kernel is compiled with CONFIG_EFI_STUB=y.
>
> tboot_addr is at offset 88. Offset 64 is an ASCII string that says:
> "Use a boot loader.
>
> Remove disk and press any key to reboot..."
>
> and is from arch/x86/boot/header.S, which is placing that string
> at offset 64 (0x3c + 4) from .bstext (which precedes .bsdata) if
> CONFIG_EFI_STUB is true.
>
> #ifdef CONFIG_EFI_STUB
> .org 0x3c
> #
> # Offset to the PE header.
> #
> .long pe_header
> #endif /* CONFIG_EFI_STUB */
>
> .section ".bsdata", "a"
> bugger_off_msg:
> .ascii "Use a boot loader.\r\n"
> .ascii "\n"
> .ascii "Remove disk and press any key to reboot...\r\n"
> .byte 0
>
Most likely the "linuxefi" boot method uses the EFI handover protocol,
however. It looks like they don't start with a properly zeroed structure...
prev parent reply other threads:[~2015-12-02 2:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 1:57 tboot: non-0 tboot_addr but it is not of type E820_RESERVED Elliott, Robert (Persistent Memory)
2015-12-02 1:26 ` Elliott, Robert (Persistent Memory)
2015-12-02 2:20 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565E5556.5040703@zytor.com \
--to=hpa@zytor.com \
--cc=elliott@hpe.com \
--cc=gang.wei@intel.com \
--cc=joseph.cihula@intel.com \
--cc=linda.knippers@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=richard.l.maliszewski@intel.com \
--cc=shane.wang@intel.com \
--cc=tboot-devel@lists.sourceforge.net \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hpe.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.