From: David Ahern <dsa@cumulusnetworks.com>
To: Andi Kleen <andi@firstfloor.org>, Daniel Borkmann <daniel@iogearbox.net>
Cc: Lorenzo Colitti <lorenzo@google.com>,
Matt Bennett <Matt.Bennett@alliedtelesis.co.nz>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Luuk Paulussen <Luuk.Paulussen@alliedtelesis.co.nz>,
davem@davemloft.net
Subject: Re: Increasing skb->mark size
Date: Tue, 1 Dec 2015 21:42:45 -0800 [thread overview]
Message-ID: <565E84D5.5070009@cumulusnetworks.com> (raw)
In-Reply-To: <20151202025835.GL15533@two.firstfloor.org>
On 12/1/15 6:58 PM, Andi Kleen wrote:
>>> - skb_iff is either skb->dev->iff or 0. so it could be replaced with a
>>> single bit flag for the 0 case.
>>
>> ... and that one wouldn't work on ingress.
>
> Please explain.
skb->dev is dropped fairly early in the Rx path. skb_iif is needed for
example for IP_CMSG_PKTINFO.
next prev parent reply other threads:[~2015-12-02 5:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 20:32 Increasing skb->mark size Matt Bennett
2015-11-24 20:36 ` Florian Westphal
2015-11-24 20:56 ` Matt Bennett
2015-11-26 4:44 ` Luuk Paulussen
2015-11-30 2:08 ` Florian Westphal
2015-11-30 2:10 ` Lorenzo Colitti
2015-11-30 2:24 ` Florian Westphal
2015-11-29 8:37 ` Lorenzo Colitti
2015-11-30 1:58 ` David Miller
2015-11-30 4:10 ` Luuk Paulussen
2015-11-30 4:49 ` David Miller
2015-12-01 0:12 ` Luuk Paulussen
2015-12-01 3:55 ` David Miller
2015-12-01 4:57 ` Luuk Paulussen
2015-12-01 19:13 ` Andi Kleen
2015-12-01 22:09 ` Daniel Borkmann
2015-12-02 2:58 ` Andi Kleen
2015-12-02 5:42 ` David Ahern [this message]
2015-12-02 17:29 ` David Miller
2015-12-02 3:57 ` Lorenzo Colitti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565E84D5.5070009@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=Luuk.Paulussen@alliedtelesis.co.nz \
--cc=Matt.Bennett@alliedtelesis.co.nz \
--cc=andi@firstfloor.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.