Re: [Qemu-devel] [PATCH] vhost-user: verify that number of queues is non-zero

[Jason Wang <jasowang@redhat.com>]

On 12/01/2015 09:32 PM, Victor Kaplansky wrote:
> Fix QEMU crash when -netdev type=vhost-user,queues=n is passed
> with zero number of queues.
>
> Signed-off-by: Victor Kaplansky <victork@redhat.com>
> ---
>  net/vhost-user.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/net/vhost-user.c b/net/vhost-user.c
> index 5071602..b368a90 100644
> --- a/net/vhost-user.c
> +++ b/net/vhost-user.c
> @@ -316,6 +316,11 @@ int net_init_vhost_user(const NetClientOptions *opts, const char *name,
>      }
>  
>      queues = vhost_user_opts->has_queues ? vhost_user_opts->queues : 1;
> +    if (queues < 1) {
> +        error_setg(errp,
> +                   "vhost-user number of queues must be bigger than zero");
> +        return -1;
> +    }
>  
>      return net_vhost_user_init(peer, "vhost_user", name, chr, queues);
>  }

Acked-by: Jason Wang <jasowang@redhat.com>