From: "Matias Bjørling" <mb@lightnvm.io>
To: Wenwei Tao <ww.tao0320@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] lightnvm: use flags as input parameter
Date: Wed, 2 Dec 2015 12:35:54 +0100 [thread overview]
Message-ID: <565ED79A.10603@lightnvm.io> (raw)
In-Reply-To: <1449055543-3736-1-git-send-email-ww.tao0320@gmail.com>
On 12/02/2015 12:25 PM, Wenwei Tao wrote:
> rrpc_get_blk use constant 0 as the input parameter
> of nvm_get_blk, this may result in getting gc block
> failed unexpectedly.
>
> Signed-off-by: Wenwei Tao <ww.tao0320@gmail.com>
> ---
> drivers/lightnvm/rrpc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
> index 75e59c3..d606c7a 100644
> --- a/drivers/lightnvm/rrpc.c
> +++ b/drivers/lightnvm/rrpc.c
> @@ -182,7 +182,7 @@ static struct rrpc_block *rrpc_get_blk(struct rrpc *rrpc, struct rrpc_lun *rlun,
> struct nvm_block *blk;
> struct rrpc_block *rblk;
>
> - blk = nvm_get_blk(rrpc->dev, rlun->parent, 0);
> + blk = nvm_get_blk(rrpc->dev, rlun->parent, flags);
> if (!blk)
> return NULL;
>
>
Thanks Tao, applied.
prev parent reply other threads:[~2015-12-02 11:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 11:25 [PATCH] lightnvm: use flags as input parameter Wenwei Tao
2015-12-02 11:35 ` Matias Bjørling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565ED79A.10603@lightnvm.io \
--to=mb@lightnvm.io \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ww.tao0320@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.