All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: KVM <kvm@vger.kernel.org>,
	linux-s390 <linux-s390@vger.kernel.org>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Jens Freimann <jfrei@linux.vnet.ibm.com>,
	Alexander Graf <agraf@suse.de>
Subject: Re: [GIT PULL 04/23] KVM: s390: rewrite vcpu_post_run and drop out early
Date: Wed, 2 Dec 2015 13:20:29 +0100	[thread overview]
Message-ID: <565EE20D.4010008@redhat.com> (raw)
In-Reply-To: <1449054384-76374-5-git-send-email-borntraeger@de.ibm.com>



On 02/12/2015 12:06, Christian Borntraeger wrote:
> +	memcpy(&vcpu->run->s.regs.gprs[14], &vcpu->arch.sie_block->gg14, 16);

This is preexisting but... boy it's ugly. :)

Do you gain much over the simpler

	vcpu->run->s.regs.gprs[14] = vcpu->arch.sie_block->gg14;
	vcpu->run->s.regs.gprs[15] = vcpu->arch.sie_block->gg15;

?

Paolo

  reply	other threads:[~2015-12-02 12:20 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02 11:06 [GIT PULL 00/23] KVM: s390 features, kvm_get_vcpu_by_id and stat for 4.5 Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 01/23] KVM: Use common function for VCPU lookup by id Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 02/23] KVM: use heuristic for fast " Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 03/23] KVM: Remove unnecessary debugfs dentry references Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 04/23] KVM: s390: rewrite vcpu_post_run and drop out early Christian Borntraeger
2015-12-02 12:20   ` Paolo Bonzini [this message]
2015-12-02 13:04     ` Christian Borntraeger
2015-12-02 13:05       ` Paolo Bonzini
2015-12-02 14:00         ` Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 05/23] s390/sclp: introduce checks for ESCA and HVS Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 06/23] KVM: s390: Generalize access to IPTE controls Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 07/23] KVM: s390: Generalize access to SIGP controls Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 08/23] KVM: s390: Provide SCA-aware helpers for VCPU add/del Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 09/23] KVM: s390: Introduce new structures Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 10/23] KVM: s390: Make provisions for ESCA utilization Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 11/23] KVM: s390: Introduce switching code Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 12/23] KVM: s390: Enable up to 248 VCPUs per VM Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 13/23] KVM: s390: fast path for sca_ext_call_pending Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 14/23] KVM: s390: we always have a SCA Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 15/23] KVM: s390: fix SCA related races and double use Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 16/23] KVM: s390: always set/clear the SCA sda field Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 17/23] KVM: s390: cleanup sca_add_vcpu Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 18/23] KVM: s390: don't switch to ESCA for ucontrol Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 19/23] s390/sclp: introduce check for SIE Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 20/23] s390: show virtualization support in /proc/cpuinfo Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 21/23] KVM: s390: don't load kvm without virtualization support Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 22/23] KVM: s390: remove pointless test_facility(2) check Christian Borntraeger
2015-12-02 11:06 ` [GIT PULL 23/23] KVM: s390: remove redudant assigment of error code Christian Borntraeger
2015-12-02 12:50 ` [GIT PULL 00/23] KVM: s390 features, kvm_get_vcpu_by_id and stat for 4.5 Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565EE20D.4010008@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=jfrei@linux.vnet.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.